Ticket #5154 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

[IDA] ConvFit - Unexpected Exception On Running Sequential Fit

Reported by: Peter Parker Owned by: Peter Parker
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

Running sequential fit when no fit function has been selected (either a delta function or lorenztian) throws an unexpected error. A dialog needs to be presented to the user instead, just like in the case of pressing "Run".

In fact, that dialog message is too vague, and should also probably be changed to something like "Check your input: at least one fitting function should be selected".

Attachments

osi94901_graphite002_red.nxs​ (874.3 KB) - added by Peter Parker 8 years ago.
Reduction File
osi94910_graphite002_res.nxs​ (195.7 KB) - added by Peter Parker 8 years ago.
Resolution File

Change History

comment:1 Changed 8 years ago by Peter Parker

Refs #5154 - Implemented better input validation in Fury and ConvFit

In both tabs, users will now be prompted with a more informative dialog on incorrect input.

Exception is now caught and is dealt with via a dialog.

Changeset: ff035743041761de253800eefdb363a552074910

comment:2 Changed 8 years ago by Peter Parker

Refs #5154 - Implemented better input validation in Fury and ConvFit

In both tabs, users will now be prompted with a more informative dialog on incorrect input.

Exception is now caught and is dealt with via a dialog.

Changeset: ff035743041761de253800eefdb363a552074910

comment:3 Changed 8 years ago by Peter Parker

  • Status changed from new to accepted

comment:4 Changed 8 years ago by Peter Parker

  • Status changed from accepted to assigned

comment:5 Changed 8 years ago by Peter Parker

  • Status changed from assigned to accepted

Changed 8 years ago by Peter Parker

Reduction File

Changed 8 years ago by Peter Parker

Resolution File

comment:6 Changed 8 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

Closing. Testing details to follow.

comment:7 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:8 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Dialog says: "Please check your input: No fit function has been selected."

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6000

Note: See TracTickets for help on using tickets.