Ticket #5162 (closed: fixed)
Indirect CTE: Ability to specify default grouping file in instrument parameter file.
| Reported by: | Stuart Campbell | Owned by: | Stuart Campbell |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | peter.parker@… | Blocked By: | |
| Blocking: | Tester: | Peter Parker |
Description
Add the ability to specify the default grouping file in the instrument parameter file.
Change History
comment:2 Changed 8 years ago by Stuart Campbell
Refs #5162. Added properties for the mask and grouping directories.
Added groupingFiles.directory property. Added maskFiles.directory property.
Changeset: a3d26ea352ca38f9b8b617f8dd0c2c0131d1a4b7
comment:3 Changed 8 years ago by Stuart Campbell
Refs #5162. Added grouping parameters to BASIS parameter file.
Added Workflow.GroupingMethod Added Workflow.GroupingFile
Changeset: 9dddd874947d3468049f85523f620eb0d0dcc76d
comment:4 Changed 8 years ago by Stuart Campbell
Refs #5162. Will use grouping file from parameter file.
It will now check for a 'File' grouping method and if set it will then read the Workflow.GroupingFile parameter and set this to be the grouping_policy
Changeset: b6dd74515538993fe920d535cae0e8c582518381
comment:5 Changed 8 years ago by Stuart Campbell
- Status changed from accepted to verify
- Resolution set to fixed
To Test:
- Start the Convert To Energy GUI
- Select BASIS
- Enter a BASIS (event) nexus filename
- Run
Now look at the history of the output workspace, it should contain a grouping step with the file BASIS_Grouping.xml and there should only be 56 histograms.
comment:6 Changed 8 years ago by Stuart Campbell
Refs #5162. Added properties for the mask and grouping directories.
Added groupingFiles.directory property. Added maskFiles.directory property.
Changeset: a3d26ea352ca38f9b8b617f8dd0c2c0131d1a4b7
comment:7 Changed 8 years ago by Stuart Campbell
Refs #5162. Added grouping parameters to BASIS parameter file.
Added Workflow.GroupingMethod Added Workflow.GroupingFile
Changeset: 9dddd874947d3468049f85523f620eb0d0dcc76d
comment:8 Changed 8 years ago by Stuart Campbell
Refs #5162. Will use grouping file from parameter file.
It will now check for a 'File' grouping method and if set it will then read the Workflow.GroupingFile parameter and set this to be the grouping_policy
Changeset: b6dd74515538993fe920d535cae0e8c582518381
comment:9 Changed 8 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:11 Changed 8 years ago by Peter Parker
- Blocked By 5198 removed
No longer blocked by 5198 - a clean install of Mantid solved the problem.
comment:12 Changed 8 years ago by Peter Parker
Stu, I've given this a go with BSS_11841_event.nxs from the AutoTestData folder, and while it does work, I get approx ~7000 errors reported to the log, of the following form:
Pixel w/ ID = 8192 Cannot Be Located ... Pixel w/ ID = 15871 Cannot Be Located
Not sure if this is expected functionality or whether you want me to open another ticket for it. It does take my primitive PC a long while to display all those errors!
comment:13 Changed 8 years ago by Stuart Campbell
Yes, it is expected... it is because the BASIS NeXus files contain some detectors pixels that don't physically exist. If it is a problem for you then create a ticket for me on the next release.
comment:14 Changed 8 years ago by Peter Parker
- Status changed from verifying to closed
I thought that might be the case. Now you've confirmed that it's expected, I dont have any particular problem with it.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6008
