Ticket #5166 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Add Fitting function to Calibrate end of Tube

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Implement MATLAB code 

 x=0:0.01:1;
p = [1 1 1 1];
if (p(4) <0)
    p(4)=0;  %this variable cannot go below zero
end

 if (p(1) > 0)
   yth=(p(1)*erfc((p(2)-x)/p(3)))+p(4);
 end
 if (p(1) < 0)
     yth=((-2*p(1))+(p(1)*erfc((p(2)-x)/p(3))))+p(4);
 end    

plot(x,yth)

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:2 Changed 8 years ago by Karl Palmen

Fitting function passes simple tests in MantidPlot re #5166

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 32de3805c60ed8c5cb7911ce7814b28b32c75a29

comment:3 Changed 8 years ago by Karl Palmen

Prevent parameter D from being negative re #5166

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 87c3ff3bcdbcb960aedb409aa12718f9100959ad

comment:4 Changed 8 years ago by Nick Draper

  • Owner set to Karl Palmen
  • Status changed from new to assigned

comment:5 Changed 8 years ago by Karl Palmen

Done, but unit test needs adding.

comment:6 Changed 8 years ago by Karl Palmen

Added unit test for fitting function of re #5166

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: eab6fbebbdfeaf04d0cc21888eb25e7c5f2707eb

comment:7 Changed 8 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:8 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 8 years ago by Karl Palmen

Added unit test for fitting function of re #5166

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: eab6fbebbdfeaf04d0cc21888eb25e7c5f2707eb

comment:10 Changed 8 years ago by Karl Palmen

If your have any queries about testing, ask Anders Markvardsen.

comment:11 Changed 8 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:12 Changed 8 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Try to fit a dataset which produced expected fits and unit tests look good

comment:13 Changed 7 years ago by Arturs Bekasovs

Last edited 7 years ago by Arturs Bekasovs (previous) (diff)

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6012

Note: See TracTickets for help on using tickets.