Ticket #5187 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

SliceViewer doesn't plot Workspace2Ds correctly

Reported by: Michael Reuter Owned by: Janik Zikovsky
Priority: critical Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

There seems to be some issue with the SliceViewer and plotting Workspace2Ds. The scales on vertical axis seems to be way off. On OSX, there seems to be an issue with the axis titles. A screenshot is attached showing the issue.

Attachments

Workspace2D_PlotIssue.png (145.9 KB) - added by Michael Reuter 8 years ago.
Figure that shows the plotting issues.
Transposed_WS.png (59.3 KB) - added by Michael Reuter 8 years ago.
Plot showing issue with axis labels on transposed workspace.

Change History

Changed 8 years ago by Michael Reuter

Figure that shows the plotting issues.

comment:1 Changed 8 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Janik Zikovsky

Refs #5187: fix non-spectra axis in SliceViewer

for Workspace2D

Changeset: d41ccd5c7c6d796b083e53bfd43e61eb7746b4bc

comment:3 Changed 8 years ago by Janik Zikovsky

Refs #5187 handle line plot from a Workspace2D

in SliceViewer, but only for perpendicular lines. Uses Rebin2D

Changeset: 7083e29f27047e88320226e94bc06212db9176a2

comment:4 Changed 8 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

I'm going to say this is "fixed" in that it seems working and stable, but it probably needs some polishing.

In particular, the algorithm assumes the vertical axis is sorted ascending. Not sure what happens if it is sorted descending or unsorted...

comment:5 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

Works in Windows 7

comment:7 Changed 8 years ago by Michael Reuter

  • Status changed from closed to reopened
  • Resolution fixed deleted

Transposed workspaces have garbled axis labels and area normalization should be off as it makes the vertical scale different from the color fill plot.

Changed 8 years ago by Michael Reuter

Plot showing issue with axis labels on transposed workspace.

comment:8 Changed 8 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:9 Changed 8 years ago by Janik Zikovsky

Refs #5187: fix dimension labels and volume (area) normalization

for WS2Ds in SliceViewer. I did not disable the VolumeNormalization but it gets switched to no normalization by default when opening (except via the plotSlice method). Instead I fixed the calculation so that it would be properly doing area normalization, in case anyone wants that.

Changeset: 3b6869280fed52af9a9c0b92ebab22a953948a9f

comment:10 Changed 8 years ago by Janik Zikovsky

Also, I was not able to reproduce the issue in the screenshot with the transposed workspace...

comment:11 Changed 8 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying

comment:13 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

Works on Ubuntu 12 (It was bad before the last change)

comment:14 Changed 8 years ago by Janik Zikovsky

Refs #5187: fix non-spectra axis in SliceViewer

for Workspace2D

Changeset: d41ccd5c7c6d796b083e53bfd43e61eb7746b4bc

comment:15 Changed 8 years ago by Janik Zikovsky

Refs #5187 handle line plot from a Workspace2D

in SliceViewer, but only for perpendicular lines. Uses Rebin2D

Changeset: 7083e29f27047e88320226e94bc06212db9176a2

comment:16 Changed 8 years ago by Janik Zikovsky

Refs #5187: fix dimension labels and volume (area) normalization

for WS2Ds in SliceViewer. I did not disable the VolumeNormalization but it gets switched to no normalization by default when opening (except via the plotSlice method). Instead I fixed the calculation so that it would be properly doing area normalization, in case anyone wants that.

Changeset: 3b6869280fed52af9a9c0b92ebab22a953948a9f

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6033

Note: See TracTickets for help on using tickets.