Ticket #5192 (closed: fixed)
Installers should ship pyc files
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Gesner Passos |
Description
Currently our installers only ship python script files, .py, not their compiled variants, .pyc (or .pyo).
This can cause problems when we decide to remove a script from the distribution as a user will still have a pyc file remaining and it will act as though the module is still there.
We should ship both so that the code can still be viewed by users but will allow the installers to remove the pyc files as well.
Change History
comment:1 Changed 8 years ago by Nick Draper
- Owner set to Martyn Gigg
- Status changed from new to assigned
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:3 Changed 8 years ago by Martyn Gigg
Copy instead of copy_if_different. Refs #5192
Changeset: d0b27bb1efa02d969452c9fcc5f03940ae38c9b6
comment:4 Changed 8 years ago by Martyn Gigg
Missed a copy_if_different usage. Refs #5192
Changeset: 33c85bf23a0c4f8e2af893e961ae05e24807834e
comment:5 Changed 8 years ago by Martyn Gigg
Generate the pyc file properly. Refs #5192
Changeset: d0de1820b2e4acc4711dc6e92012129cc81f58ac
comment:6 Changed 8 years ago by Martyn Gigg
Use the correct src directory for python files. Refs #5192
Changeset: 4ccda8d48d81336a0199b1e96518d0b65b571dc8
comment:7 Changed 8 years ago by Martyn Gigg
Fix windows install commands. Refs #5192
Changeset: d6ada8c595d853c8bbd7dcb5e1da197495007b80
comment:8 Changed 8 years ago by Martyn Gigg
Fix python install file lists Refs #5192
Also only ship the pyd files for windows.
Changeset: c503a8a760af970825e2a66b675c8d51afc92818
comment:10 Changed 8 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:11 Changed 8 years ago by Martyn Gigg
Go back to copy_if_different Refs #5192
Keeps the copying to a minimum since most files don't change very often.
Changeset: 325396250684915f02d495d65d80e77b474dfd4e
comment:12 Changed 8 years ago by Martyn Gigg
Ship .pyc files along with all .py files. Refs #5192
Changeset: 306f3e937b05664e37ebe12b19bee823bc291b72
comment:13 Changed 8 years ago by Martyn Gigg
Copy instead of copy_if_different. Refs #5192
Changeset: d0b27bb1efa02d969452c9fcc5f03940ae38c9b6
comment:14 Changed 8 years ago by Martyn Gigg
Missed a copy_if_different usage. Refs #5192
Changeset: 33c85bf23a0c4f8e2af893e961ae05e24807834e
comment:15 Changed 8 years ago by Martyn Gigg
Generate the pyc file properly. Refs #5192
Changeset: d0de1820b2e4acc4711dc6e92012129cc81f58ac
comment:16 Changed 8 years ago by Martyn Gigg
Use the correct src directory for python files. Refs #5192
Changeset: 4ccda8d48d81336a0199b1e96518d0b65b571dc8
comment:17 Changed 8 years ago by Martyn Gigg
Fix windows install commands. Refs #5192
Changeset: d6ada8c595d853c8bbd7dcb5e1da197495007b80
comment:18 Changed 8 years ago by Martyn Gigg
Fix python install file lists Refs #5192
Also only ship the pyd files for windows.
Changeset: c503a8a760af970825e2a66b675c8d51afc92818
comment:19 Changed 8 years ago by Martyn Gigg
Go back to copy_if_different Refs #5192
Keeps the copying to a minimum since most files don't change very often.
Changeset: 325396250684915f02d495d65d80e77b474dfd4e
comment:20 Changed 8 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:21 Changed 8 years ago by Gesner Passos
- Status changed from verifying to closed
I've generated a script that list all the mismatches. All the .py files are being distributed with the .pyc files related, except those inside script/Interface/templates that should not distribute the pyc files.
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6038
