Ticket #5200 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

[C2E] - Detailed balance shouldn't divide by 0.

Reported by: Robert Whitley Owned by: Peter Parker
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

If you enter 0 as Kelvin then a ZeroDevision log error is thrown. See #4842.

Change History

comment:1 Changed 8 years ago by Peter Parker

Refs #5200 - Disallow zero.

Changeset: d419c8f350597c26a95ac2d030afee7affd71823

comment:2 Changed 8 years ago by Peter Parker

Refs #5200 - Disallow zero.

Changeset: d419c8f350597c26a95ac2d030afee7affd71823

comment:3 Changed 8 years ago by Peter Parker

Refs #5200 - Disallow zero.

Changeset: d419c8f350597c26a95ac2d030afee7affd71823

comment:4 Changed 8 years ago by Peter Parker

  • Status changed from new to accepted

comment:5 Changed 8 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:7 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Entered 0 and nothing crashed!

comment:8 Changed 8 years ago by Stuart Campbell

  • Status changed from closed to reopened
  • Resolution fixed deleted

I just noticed in the scripting console output I get the following: 

ZeroDivisionError: float division
  at line 10 in '<Interface>'
  caused by line 494 in '/SNS/users/scu/checkout/mantidproject/mantid/Code/Mantid/scripts/reduction/reducer.py'
  caused by line 708 in '/SNS/users/scu/checkout/mantidproject/mantid/Code/Mantid/scripts/Inelastic/inelastic_indirect_reduction_steps.py'

comment:9 Changed 8 years ago by Peter Parker

Refs #5200 - Stop DBZ error.

Actually do something with the news that the user has typed in an incorrect value ...

Changeset: bdae8c6eccea736ed56daca3ac4460416a54cc30

comment:10 Changed 8 years ago by Peter Parker

  • Status changed from reopened to accepted

comment:11 Changed 8 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

That should do it Stu, sorry about that.

comment:12 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying

comment:13 Changed 8 years ago by Peter Parker

Refs #5694 - Remove accidentally added temp grouping file.

Basically just proving that I'm World Chamption at making simple jobs way way way harder than they have any right to be.

Changeset: d8526764f5f4150fac52a7e495764ad1b4f1863f

comment:14 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Cool - it now tells me to check the field.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6046

Note: See TracTickets for help on using tickets.