Ticket #5219 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

History not saved correctly when it involves strings with commas

Reported by: Andrei Savici Owned by: Peter Parker
Priority: blocker Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Start with this:

LoadEventNexus(Filename='CNCS_7860_event.nxs',OutputWorkspace='IWS')
SetUB(Workspace='IWS',a='3.6429999999999998',b='3.6429999999999998',c='5.7809999999999997',gamma='120',u='1,1,0',v='0,0,1')

Then save the workspace as nexus file, and try to load it. When I look at the history, I get

######################################################################
#Python Script Generated by GeneratePythonScript Algorithm
######################################################################
LoadEventNexus(Filename=r'/home/andrei/Mantid/mantid/Test/AutoTestData/CNCS_7860_event.nxs',OutputWorkspace='IWS')
SetUB(Workspace='IWS',a='3.6429999999999998',b='3.6429999999999998',c='5.7809999999999997',gamma='120',u='1',v='0')
Load(Filename='/home/andrei/Desktop/test_save.nxs',OutputWorkspace='test_save')

Notice that the u and v vectors are not saved correctly in the SetUB. I had similar experience with Mask detectors, when I input a detector list as comma separated integers in a string, in the history I get only the first value. Not good :(

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Owner set to Peter Parker
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Peter Parker

I've tracked this down to LoadNexusProcessed.cpp, at around line 1222. Basically properties in the history of a Nexus file aren't being loaded properly if they contain comma separated lists. I'll see if I can find an easy fix that doesn't break anything.

comment:3 Changed 8 years ago by Peter Parker

Refs #5219 - Correct history parsing for LoadNexusProcessed.

Hopefully made the parsing of processed nexus file histories a little more robust.

Changeset: f6b2d4fb1b83fd3c589523a38cd7a79125115a5b

comment:4 Changed 8 years ago by Peter Parker

  • Status changed from assigned to accepted

comment:5 Changed 8 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:7 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:8 Changed 8 years ago by Peter Parker

Refs #5219 - Correct history parsing for LoadNexusProcessed.

Hopefully made the parsing of processed nexus file histories a little more robust.

Changeset: f6b2d4fb1b83fd3c589523a38cd7a79125115a5b

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6065

Note: See TracTickets for help on using tickets.