Ticket #5226 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Load can not load SQW

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.0
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description (last modified by Alex Buts) (diff)

At the moment generic load algorithm can not load SQW, despite particular sqw loader exist.

Should be dealt with after loadSQW is working properly.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Owner set to Alex Buts
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:4 Changed 8 years ago by Alex Buts

Last edited 8 years ago by Alex Buts (previous) (diff)

comment:5 Changed 8 years ago by Alex Buts

  • Milestone changed from Release 2.4 to Release 2.5

comment:6 Changed 7 years ago by Alex Buts

  • Milestone changed from Release 2.5 to Release 2.6

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from VATES to User Interface

comment:9 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:10 Changed 7 years ago by Alex Buts

  • Status changed from new to inprogress
  • Description modified (diff)

comment:11 Changed 7 years ago by Alex Buts

refs #5226 inherited loadSQW from IFileLoader and initial registration

Changeset: 5e44170dfd955d1b9a3cd2a938d3b520885a0600

comment:12 Changed 7 years ago by Alex Buts

refs #5226 Hopefully implemented

though can not find a way to modify the list of acceptable extensions

Changeset: 2224bdc2068e4bb3d15f1543cd4aeab2060683f3

comment:13 Changed 7 years ago by Alex Buts

refs #5226 Removed redundant code (and fix Unix warnings)

Changeset: eba288083ca7a0ad8e41464d273169a5f9221c64

comment:14 Changed 7 years ago by Alex Buts

  • Blocked By 4846 removed

Load algorithm should be able to recognize sqw file (e.g. AutoTestData/test_horace_reader.sqw) , invoke LoadSQW interface and load sqw file properly.

Worth checking if it properly recognizes .SQW extension on Unix (it is somewhere in file helper and related to it so a person well familiar with this helper can give answer directly)

comment:15 Changed 7 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:16 Changed 7 years ago by Alex Buts

  • Milestone changed from Backlog to Release 3.0

comment:17 Changed 7 years ago by Alex Buts

refs #5226 Minor change -- adding sqw to the list of known extensions.

Otherwise, when loading sqw, it complains about unknown extension when logging is done in debug mode

Changeset: dfb86ccc61e282d628e76e33a7d4cda55b97db49

comment:18 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:19 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/5226_Loader4LoadSQW'

comment:20 Changed 7 years ago by Samuel Jackson

Load now appears to work fine when opening .sqw files. I tested this on Ubuntu 12.04 and it seemed to recognise the .sqw extension with no problems.

As discussed, LoadSQW doesn't overwrite an existing workspace with the same name in the ADS, but that can be investigated in another ticket.

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6072

Note: See TracTickets for help on using tickets.