Ticket #5253 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

ConvertToMDEvents coplanar viewing axes

Reported by: Andrei Savici Owned by: Andrei Savici
Priority: minor Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Alex, Buts Blocked By:
Blocking: Tester: Michael Reuter

Description

The u,v,w axes are not supposed to be coplanar. But if one chooses u=(1,0,0) v=(0,0,1) and leaves w the default, w is (0,0,1). There needs to be a check (u X v).w!=0

Change History

comment:1 Changed 8 years ago by Andrei Savici

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Andrei Savici

Check if projections are coplanar. Refs #5253

Changeset: 34d18e1421634ee15c1c22614b7150149201ce0e

comment:3 Changed 8 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

To test: 

Load(Filename='CNCS_7860_event.nxs',OutputWorkspace='CNCS_7860_event')
ConvertUnits(InputWorkspace='CNCS_7860_event',OutputWorkspace='CNCS_7860_event',Target='DeltaE',EMode='Direct',EFixed='3')
ConvertToMDEvents(InputWorkspace='CNCS_7860_event',OutputWorkspace='w1',QDimensions='Q3D',QConversionScales='HKL',MinValues='-5,-5,-5,-5',MaxValues='5,5,5,5',Uproj='1,1,0',Vproj='2,2,0',Wproj='0,0,1')
ConvertToMDEvents(InputWorkspace='CNCS_7860_event',OutputWorkspace='w2',QDimensions='Q3D',QConversionScales='HKL',MinValues='-5,-5,-5,-5',MaxValues='5,5,5,5',Uproj='1,1,0',Vproj='2,-2,0',Wproj='0,0,1')

w1 should have axes [H,0,0],[0,K,0],[0,0,L] w2 should have axes [H,H,0],[2H,-2H,0],[0,0,L]

comment:4 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:5 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

When running the above script, both datasets come out identical. This should not be the case.

comment:6 Changed 8 years ago by Andrei Savici

  • Status changed from reopened to accepted

Code was moved to ConvertToMD

comment:7 Changed 8 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying

Using ConvertToMD does produce appropriate results.

comment:9 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6099

Note: See TracTickets for help on using tickets.