Logic of Windows Installer Warnings

[Owen Arnold]

Suggested by Russell Taylor that we should try to distinguish between a firt-time install and what looks to be an install with a previous mantid instance.

We can probably do this by checking to see if the c:\mantidinstall directory exists as well as the existing check for Uninstall.exe.

[Owen Arnold]

refs #5258. Better checking for old style install.

Changeset: bfc8e7785a0e4b67bef04b3588db223dd83eaf6e

[Owen Arnold]

Tester:

Here are some tests to conduct on Windows

1) On a clean machine, Should NOT get a YES/NO message box about old style previous installs.

2) On a machine that has had the new installer-style Mantid already installed (v2.1 and up) should NOT get a YES/NO message box about old style previous installs.

3) On a machine that already has the old style mantid MSI installed (v.2.0 and below) should get a YES/NO message box about old style previous installs.

[Dereck Kachere]

Fully uninstalled Mantid; the Uninstall.exe is no longer present, nor was the c:\mantidinstall directory itself.

(Clean machine) Mantid v2.1.1430 - Yes/No option NOT there. (Clean machine) Mantid v2.1.1 & v2.1.0- Yes/No option IS THERE.

(Machine with v2.1 and up) Mantid v2.1.0 to v2.1.1430 - Yes/No option NOT there.

(Machine with v2.0 and below) Mantid v1.29.12931 to v1.30.14858 - Yes/No option NOT there but going from v1.29.12931 to v2.0.1 requires removal of previous versions via Control Panel before continuing with the install.

[Owen Arnold]

I've spoken to Dereck about this. There was a problem with my description. I still think that this is fixed.

[Dereck Kachere]

Yes, I misunderstood description; everything is working as it should.

[Stuart Campbell]

This ticket has been transferred to github issue ​6104