Ticket #5266 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

ScriptWindow changed marker disppears on pressing esc

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

To reproduce:

  • Open the script window;
  • Start typing some code, a star will appear to indicate the contents have changed;
  • Click File->Save (in the script window) and the file browser will appear;
  • Immediately press Esc and the browser will disappear but so will the marker to indicate that the contents have changed.

The file can still be saved & closing the application does still prompt the user about saving so no work should be lost.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Owner set to Martyn Gigg
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:3 Changed 8 years ago by Martyn Gigg

  • Status changed from assigned to accepted

comment:4 Changed 8 years ago by Martyn Gigg

Fix modified state of script tab when save cancelled. Refs #5266

Changeset: c477fe8f7041927baca1f99b1333c652da4405f6

comment:5 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Martyn Gigg

Fix modified state of script tab when save cancelled. Refs #5266

Changeset: c477fe8f7041927baca1f99b1333c652da4405f6

comment:7 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:8 Changed 8 years ago by Owen Arnold

Yes, we no longer loose the star, but after the browser is closed, the user can close out of the python window without being prompted about the unsaved changes. I assume this is the desired behaviour?

comment:9 Changed 8 years ago by Martyn Gigg

Closing the Python window actually only hides it and on quitting MantidPlot it will ask about saving.

comment:10 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6112

Note: See TracTickets for help on using tickets.