Ticket #5285 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

GenerateHistogram() method on MatrixWorkspace

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: mikkelsond@… Blocked By:
Blocking: Tester: Vickie Lynch

Description

Add a virtual GenerateHistogram() method that can be called on both Workspace2D and EventWorkspace. The Workspace2D version rebins, the EventWorkspace one simply bins.

Change History

comment:1 Changed 8 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Janik Zikovsky

Refs #5285 MatrixWorkspace-level generateHistogram() method

Changeset: 4c801e41a343345f576b6843b6b6f738363337b5

comment:3 Changed 8 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Dennis Mikkelson

  • Status changed from verify to reopened
  • Resolution fixed deleted

Add generateHistogram method to IEventWorkspace.h, so it is visible from API.

comment:5 Changed 8 years ago by Dennis Mikkelson

Add generateHistogram() to IEventWorkspace.h

refs #5285

Changeset: 213d412fc1db8477a42942e5b0a81aa0aed17465

comment:6 Changed 8 years ago by Dennis Mikkelson

Re: 5285 Add convertToBinBoundary() to VectorHelper

Since VectorHelper::rebin() requires current X vector with one more entry than the current Y vector, even if the Workspace2D is a distribution, we need to adjust the current X vector before calling rebin. This is a convenience method that essentially reverses the convertToBinCentre() method, so it seems to belong in VectorHelper. refs #5285

Changeset: bc2a6e35c3a27e33f5b156d4fcb71343856d4c16

comment:7 Changed 8 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:8 Changed 8 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

I believe Dennis' last commits added what was needed for this ticket. Resolving as fixed.

comment:9 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:10 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to closed

Works for both types of workspaces

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6131

Note: See TracTickets for help on using tickets.