Ticket #5293 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

RunInfo - Create Algorithm to Produce Run Info Table

Reported by: Peter Parker Owned by: Peter Parker
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Dereck Kachere

Description

Timmy would like to see a "wrapper" algorithm which uses CreateLogPropertyTable to do the following:

  • Accept a range of runs and an OutputWorkspace name as the only input.
  • Load the files with corresponding run numbers, but in batches.
  • With each batch, compile a TableWorkspace of information from each run.
  • Combine each table into a single output result.

I have seen files from different facilities with different log properties available, but I need to better understand these differences - i.e. does it depend on file type or instrument as well as facility?

Change History

comment:1 Changed 8 years ago by Peter Parker

Refs #5293 - Slight adjustment to MantidFramework.py

Allow for declareWorkspaceProperty([...] Type=ITableWorkspace) in PythonAlgorithms - currently using it would raise an exception.

Changeset: 5937fcdc93cba9bd212c3a0f8df5ac598c9f9700

comment:2 Changed 8 years ago by Peter Parker

Refs #5293 - First attempt at a "RetrieveRunInfo" PythonAlgorithm.

Currently, only accepts .raw files, and only when the facility is set to ISIS.

Changeset: f8276577babdf0ce30206ebc2025f8128ffb8c90

comment:3 Changed 8 years ago by Peter Parker

Refs #5293 - Added needed import.

Changeset: c1433865ab64c082e85265037eb1122709222b86

comment:4 Changed 8 years ago by Peter Parker

Refs #5293 - Added needed import.

Changeset: c1433865ab64c082e85265037eb1122709222b86

comment:5 Changed 8 years ago by Peter Parker

Refs #5293 - Added needed import.

Changeset: c1433865ab64c082e85265037eb1122709222b86

comment:6 Changed 8 years ago by Peter Parker

Refs #5589 #5293 - RetrieveRunInfo modification + unit tests.

Modifications made to how the aglogrithm works.

Unit tests added.

Changeset: bed93dc9123eb7515e6266e9bea96710bcfcb519

comment:7 Changed 8 years ago by Peter Parker

  • Status changed from new to accepted

comment:8 Changed 8 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

This algorithm is now fully implemented, with unit tests.

To test, make sure that your favourite ISIS instrument (who's run files contain the log properties "inst_abrv", "run_number", "user_name", "run_title" and "hd_dur") can be used with this algorithm, and that the output is as you expect.

At the very least, all TOSCA and IRIS runs should probably be supported by this algorithm.

The algorithm should also validate the input and report reasonable errors.

comment:9 Changed 8 years ago by Peter Parker

Refs #5589 #5293 - RetrieveRunInfo modification + unit tests.

Modifications made to how the aglogrithm works.

Unit tests added.

Changeset: bed93dc9123eb7515e6266e9bea96710bcfcb519

comment:10 Changed 8 years ago by Dereck Kachere

  • Status changed from verify to verifying
  • Tester set to Dereck Kachere

comment:11 Changed 8 years ago by Dereck Kachere

  • Status changed from verifying to closed

Ran the test on IRIS and TOSCA. The only inputs were indeed the range of runs and an output workspace.

The abbreviation for the instrument, run number, username and run title were displayed displayed and when I tried re-using the same name for the destination workspace, a warning message appeared, just as it should do from the code.

Ran test on POLARIS as well and that worked fine.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6139

Note: See TracTickets for help on using tickets.