Ticket #5308 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

[IDA] - General Reshuffling of Code

Reported by: Peter Parker Owned by: Peter Parker
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Reshuffle the code to better facilitate improvements, and to make the process of running, validating and setting up each tab more uniform.

This will involve some renaming and splitting of the large and unwieldy IDA class into subclasses.

Hopefully this will also make the IDA code easier to understand and to come to grips with.

Change History

comment:1 Changed 8 years ago by Peter Parker

Refs #5308 - Split IDA into subclasses.

IDA is now a number of classes:

  • IndirectDataAnalysis. Main "controller" class.
  • IDATab. Base class for all tabs:
    • Elwin
    • MSDFit
    • Fury
    • FuryFit
    • ConvFit
    • AbsorptionF2Py (to be renamed CalcCorr)
    • AbsCorr (to be renamed ApplyCorr)

Some standardisation of how validation works.

Introduction of Tab enums with a view to better self-document the code.

Changeset: bd6c18128be0f7083d32ffecffba229f12f40bf6

comment:2 Changed 8 years ago by Peter Parker

Refs #5308 - Moving IDA classes into their own files.

Created header and source files for IDATab, and the tab classes that derive from it. Moved code from IndirectDataAnalysis.h/.cpp to corresponding files.

Uncommented and moved fitContextMenu, fixItem and unfixItem methods into Convfit and FuryFit. Need to come up with a nicer way to factor out the similarities between these two.

Changeset: 9c4606692a4d4f60cc3fb2cb9bc591fb23837bf3

comment:3 Changed 8 years ago by Peter Parker

Refs #5308 - Add some includes.

Changeset: bb29abfbafdd1e67d2e077d708030cdf586bf782

comment:4 Changed 8 years ago by Peter Parker

Refs #5308 - A couple more.

Changeset: ea20f141b3ac964f24de842eda0fd8a49bf94798

comment:5 Changed 8 years ago by Peter Parker

Refs #5308 - And again.

Changeset: 0960ea4f41da0158eddbb3bda96aa4c38b9ed339

comment:6 Changed 8 years ago by Peter Parker

Refs #5308 - Split IDA into subclasses.

IDA is now a number of classes:

  • IndirectDataAnalysis. Main "controller" class.
  • IDATab. Base class for all tabs:
    • Elwin
    • MSDFit
    • Fury
    • FuryFit
    • ConvFit
    • AbsorptionF2Py (to be renamed CalcCorr)
    • AbsCorr (to be renamed ApplyCorr)

Some standardisation of how validation works.

Introduction of Tab enums with a view to better self-document the code.

Changeset: bd6c18128be0f7083d32ffecffba229f12f40bf6

comment:7 Changed 8 years ago by Peter Parker

Refs #5308 - Moving IDA classes into their own files.

Created header and source files for IDATab, and the tab classes that derive from it. Moved code from IndirectDataAnalysis.h/.cpp to corresponding files.

Uncommented and moved fitContextMenu, fixItem and unfixItem methods into Convfit and FuryFit. Need to come up with a nicer way to factor out the similarities between these two.

Changeset: 9c4606692a4d4f60cc3fb2cb9bc591fb23837bf3

comment:8 Changed 8 years ago by Peter Parker

Refs #5308 - Add some includes.

Changeset: bb29abfbafdd1e67d2e077d708030cdf586bf782

comment:9 Changed 8 years ago by Peter Parker

Refs #5308 - A couple more.

Changeset: ea20f141b3ac964f24de842eda0fd8a49bf94798

comment:10 Changed 8 years ago by Peter Parker

Refs #5308 - And again.

Changeset: 0960ea4f41da0158eddbb3bda96aa4c38b9ed339

comment:11 Changed 8 years ago by Peter Parker

Refs #5308 - Fix validation bug in IDA CalcCorr.

Changeset: 1a78227a47419db47994270e40b1ef15f59ac7c6

comment:12 Changed 8 years ago by Peter Parker

Refs #5308 - Added missing initialiser to list.

Changeset: e506760ec60ed13b335e32fbdc14ed7b2c8aff13

comment:13 Changed 8 years ago by Peter Parker

Refs #5308 - Split IDA into subclasses.

IDA is now a number of classes:

  • IndirectDataAnalysis. Main "controller" class.
  • IDATab. Base class for all tabs:
    • Elwin
    • MSDFit
    • Fury
    • FuryFit
    • ConvFit
    • AbsorptionF2Py (to be renamed CalcCorr)
    • AbsCorr (to be renamed ApplyCorr)

Some standardisation of how validation works.

Introduction of Tab enums with a view to better self-document the code.

Changeset: bd6c18128be0f7083d32ffecffba229f12f40bf6

comment:14 Changed 8 years ago by Peter Parker

Refs #5308 - Moving IDA classes into their own files.

Created header and source files for IDATab, and the tab classes that derive from it. Moved code from IndirectDataAnalysis.h/.cpp to corresponding files.

Uncommented and moved fitContextMenu, fixItem and unfixItem methods into Convfit and FuryFit. Need to come up with a nicer way to factor out the similarities between these two.

Changeset: 9c4606692a4d4f60cc3fb2cb9bc591fb23837bf3

comment:15 Changed 8 years ago by Peter Parker

Refs #5308 - Add some includes.

Changeset: bb29abfbafdd1e67d2e077d708030cdf586bf782

comment:16 Changed 8 years ago by Peter Parker

Refs #5308 - A couple more.

Changeset: ea20f141b3ac964f24de842eda0fd8a49bf94798

comment:17 Changed 8 years ago by Peter Parker

Refs #5308 - And again.

Changeset: 0960ea4f41da0158eddbb3bda96aa4c38b9ed339

comment:18 Changed 8 years ago by Peter Parker

Refs #5308 - Fix validation bug in IDA CalcCorr.

Changeset: 1a78227a47419db47994270e40b1ef15f59ac7c6

comment:19 Changed 8 years ago by Peter Parker

Refs #5308 - Added missing initialiser to list.

Changeset: e506760ec60ed13b335e32fbdc14ed7b2c8aff13

comment:20 Changed 8 years ago by Peter Parker

Refs #5308 - In CalcCorr, validate on a change in input.

Also, fix warnings to do with ordering of initialiser list.

Changeset: 193208f90c87cb47d3dbf8d11c32b741a866590b

comment:21 Changed 8 years ago by Peter Parker

Refs #5308 - In CalcCorr, validate on a change in input.

Also, fix warnings to do with ordering of initialiser list.

Changeset: 193208f90c87cb47d3dbf8d11c32b741a866590b

comment:22 Changed 8 years ago by Peter Parker

Need to ensure that after running a ConvFit / FuryFit that the properties table in the interface is updated with the resultant values. This functionality was apparently there previously.

comment:23 Changed 8 years ago by Peter Parker

Refs #5308 - Fix validation bug in IDA CalcCorr.

Changeset: 1a78227a47419db47994270e40b1ef15f59ac7c6

comment:24 Changed 8 years ago by Peter Parker

Refs #5308 - Added missing initialiser to list.

Changeset: e506760ec60ed13b335e32fbdc14ed7b2c8aff13

comment:25 Changed 8 years ago by Peter Parker

Refs #5308 - In CalcCorr, validate on a change in input.

Also, fix warnings to do with ordering of initialiser list.

Changeset: 193208f90c87cb47d3dbf8d11c32b741a866590b

comment:26 Changed 8 years ago by Peter Parker

Refs #5308 - Disallow Fury RangeSelectors to be moved by mouse.

Changeset: 9a01d8f0ed65e53613e248ac150543aa0dbf3beb

comment:27 Changed 8 years ago by Peter Parker

Refs #5308 - Added further validation on Fury properties.

Changeset: db8ef189606ed3767f808436552e63d431822b1d

comment:28 Changed 8 years ago by Peter Parker

Refs #5308 - Fix warning.

Changeset: bf19c60ffda900a330a0198f59d261e5c95f9a0c

comment:29 Changed 8 years ago by Peter Parker

Refs #5308 - Disallow Fury RangeSelectors to be moved by mouse.

Changeset: 9a01d8f0ed65e53613e248ac150543aa0dbf3beb

comment:30 Changed 8 years ago by Peter Parker

Refs #5308 - Added further validation on Fury properties.

Changeset: db8ef189606ed3767f808436552e63d431822b1d

comment:31 Changed 8 years ago by Peter Parker

Refs #5308 - Fix warning.

Changeset: bf19c60ffda900a330a0198f59d261e5c95f9a0c

comment:32 Changed 8 years ago by Peter Parker

  • Status changed from new to accepted

comment:33 Changed 8 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:34 Changed 8 years ago by Peter Parker

Refs #5308 - Disallow Fury RangeSelectors to be moved by mouse.

Changeset: 9a01d8f0ed65e53613e248ac150543aa0dbf3beb

comment:35 Changed 8 years ago by Peter Parker

Refs #5308 - Added further validation on Fury properties.

Changeset: db8ef189606ed3767f808436552e63d431822b1d

comment:36 Changed 8 years ago by Peter Parker

Refs #5308 - Fix warning.

Changeset: bf19c60ffda900a330a0198f59d261e5c95f9a0c

comment:37 Changed 8 years ago by Peter Parker

Not really sure how this ticket should be tested, though the interface has been tested extensively by Spencer and other users since the reshuffling.

comment:38 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:39 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

Code inspection. Looks fine.

comment:40 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6154

Note: See TracTickets for help on using tickets.