Ticket #5360 (closed: invalid)

Opened 8 years ago

Last modified 5 years ago

Possible memory leak in MDGeometry

Reported by: Peter Peterson Owned by: Owen Arnold
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

If the original data is deleted from the user interface, the geometry has a pointer that may not let go of the data. Investigate if this is happening and fix if appropriate.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to invalid

This doesn't happen, because the MDGeometry object catches the deleteNotification of the original data. Then calls sptr.reset() on that workspace.

comment:3 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:4 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

Owen is correct.

There may be a case for using a weak_ptr instead of notifications, though clients would then have to check that they weren't getting back an empty shared_ptr.

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6206

Note: See TracTickets for help on using tickets.