Accumulation mode for histograms warning

[Peter Peterson]

While the code will do what it is told, if somebody uses add mode with histograms the data will look like exponential growth in number of neutrons measured.

[Nick Draper]

http://www.mantidproject.org/Release_Notes_2_2_Full_List

[Nick Draper]

Moved to release 2.4

[Nick Draper]

Moved at the code freeze for release 2.4

[Russell Taylor]

Re #5366. Disable 'Add' option in combobox for histogram listeners.

And select 'Replace' by default instead. Marginally smarter way of doing it than the previous way.

Changeset: e00f644e66074282abce6672eb2654ff18c91db6

[Russell Taylor]

Re #5366. Minor clean-ups in LiveDataAlgorithm code.

Changeset: 353f855fcb9af834df2b94f6d36983b6e7ea512a

[Russell Taylor]

Re #5366. Forbid accumulating chunks by adding for histograms.

Changeset: 99af8626a03787d97a5c98ad3afb430b3043becb

[Russell Taylor]

To test:

• In the StartLiveData GUI, observe that 'Add' is greyed out in the 'Accumulation Method' combobox if a histogram listener is selected (any ISIS instrument), and if 'Add' was previously selected it will have changed to 'Replace'. Check also that 'Add' is re-enabled if a listener that passes back an event workspace is selected (e.g. FakeEventDataListener).

• To test the restriction in the underlying algorithm, you can try it via Python. Note that if you can't connect to the chosen instrument, that error gets in first (and is worth testing). The command StartLiveData("ISISHistoDataListener",OutputWorkspace='ws') will test that 'Add' (the default) is not allowed as the AccumulationMethod. Do check that the other options are permitted.

[Russell Taylor]

It's been pointed out that validateInputs() can get called quite a lot and it might not be desirable to repeatedly connect & disconnect to the live stream.

[Russell Taylor]

Re #5366. Ability to connect not checked in validateInputs().

Repeatedly connecting/disconnecting every time validateInputs was called is undesirable. We can now create a listener without connecting (#6553), so we can still check whether this is asking to add histograms together.

Changeset: c091e9a2cf9ce3818310cae532c56385f220c08f

[Russell Taylor]

Re #5366. Minor re-jig now we can create a listener w/o connecting.

This has removed the possibility that the method will throw because the listener cannot connect.

Changeset: e8f76299f34f2001e8a0d0da80fbe22c1f58bd4f

[Russell Taylor]

Changes in #6553 (blocking/blocked by is broken) have enabled me to do this without connecting to an actual socket.

The testing instructions in comment:9 are mostly still valid, with the exception that nothing checks a connection can be made (ahead of the algorithm starting to execute, at which point it will of course fail).

[Vickie Lynch]

All Russell's suggestions in "To test" work

[Stuart Campbell]

This ticket has been transferred to github issue ​6212