Ticket #5367 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Implement SNSLiveListener

Reported by: Ross Miller Owned by: Ross Miller
Priority: major Milestone: Release 2.3
Component: Mantid Keywords: LiveData, ADARA
Cc: Blocked By:
Blocking: #5690 Tester: Stuart Campbell

Description

Implementation of ILiveListener interface for SNS streaming data

Change History

comment:1 Changed 8 years ago by Ross Miller

Initial checkin of live event listener code

Very rough and incomplete. Doesn't actually do anything useful yet, but shouldn't crash the system.

Refs #5367

Changeset: 0f9463b1b3d10a94b54c72c966566418f31fd77e

comment:2 Changed 8 years ago by Russell Taylor

  • Keywords LiveData, ADARA added

comment:3 Changed 8 years ago by Ross Miller

Renamed ADARA files from .cc to .cpp to conform to Mantid standards

refs #5367

Changeset: 5a517f86c9f88c4cb6efa8ab51c807ab41605070

comment:4 Changed 8 years ago by Ross Miller

Minor changes from the code review

Code still isn't anywhere near ready for use. refs #5367

Changeset: de6b6f1ae0f5064cc7147df0cc729de973e79dbe

comment:5 Changed 8 years ago by Ross Miller

Converting ADARA source files to Unix line endings

Refs #5367

Changeset: 8fd273deaeda1896f08b6be1a2dc9d3402b5ef82

comment:6 Changed 8 years ago by Ross Miller

Syncing w/ most recent version of ADARA packet parsing code.

Refs #5367

Changeset: 6ba6470d8fc026a3881a8f8f25b9f87183cc6aea

comment:7 Changed 8 years ago by Ross Miller

SNSLiveEventDataListener now mostly implemented. Still needs testing.

Refs #5367

Changeset: 89a31d2201048a97f9127eec77d247042e5936c7

comment:8 Changed 8 years ago by Ross Miller

Added code to get the instrument name from the run status packet...

... and changed how the workspace was initialized. Now using Russell's code to pass XML directly into LoadInstrument. (See #5426)

Refs #5367

Changeset: e21016fdbc492cd10816734bf5dc7869860b048f

comment:9 Changed 8 years ago by Ross Miller

Use new BeamlineInfoPkt class to get the beamline name

Also merged latest ADARA packet parser code from Dave D. Refs #5367

Changeset: af767731012e4332c7d0daa36d8874dffa5c4c92

comment:10 Changed 8 years ago by Russell Taylor

  • Owner set to Ross Miller
  • Status changed from new to assigned

comment:11 Changed 8 years ago by Ross Miller

Minor changes to how the PulseID and PacketLength values are computed

This is part of Dave D.'s ADARA packet parser code. refs #5367

Changeset: da4a8860cfad012da06f6d2f30c334ee497933b9

comment:12 Changed 8 years ago by Ross Miller

Fixed off-by-one error in the BankedEventPkt parser

refs #5367

Changeset: 381ff8b3035f2344811ffd2a43e47da830718064

comment:13 Changed 8 years ago by Ross Miller

Bug fixes to the SNSLiveEventListener

Bugs found (and fixed) during integration testing: 1) Add code to the destructor to stop the background thread 2) If connect() isn't passed a valid IP address, then assume we're testing/debugging and try to connect to localhost 3) Add checks to prevent us from calling initWorkspace() more than once

Also added some logging for various errors, warnings and debug info refs #5367

Changeset: 420677b30a061e5875dd8bcd1226925572394e68

comment:14 Changed 8 years ago by Ross Miller

Two minor changes: reset the timeout timer on every packet...

...instead of just the client hello packets and add a log message when an invalid pixel id is received. refs #5367

Changeset: 808bd8bf8b64a7fefaf15161ccf104c5111eff00

comment:15 Changed 8 years ago by Ross Miller

Merge branch 'master' into LiveListener

Conflicts:

Code/Mantid/Build/CMake/hdf5-targets-mac.cmake

refs #5367

Changeset: b2302ca44a22209e88295898fca7cf24575ea49c

comment:16 Changed 8 years ago by Ross Miller

Merge branch 'master' into LiveListener

Conflicts:

Code/Mantid/Framework/DataHandling/CMakeLists.txt

refs #5367

Changeset: 7e28c321e2980d1bb3d4fa8db049c4558b386ab5

comment:17 Changed 8 years ago by Ross Miller

Replaced rxPacket() for HelloClient packets with one for Heartbeat

packets. (Because the SMS does not sent out HelloClient packets) refs #5367

Changeset: 97e23d410b5d954b06fb5011b66cb6a5039c7edd

comment:18 Changed 8 years ago by Ross Miller

Replaced gettimeofday() with Poco equivalent...

...and a couple other changes to remove some Linux-specific code. refs #5367

Changeset: 524d283d70e7ae261ce4782251c74d34762eaba7

comment:19 Changed 8 years ago by Ross Miller

Replace Linux-specific code with cross-platform code in ADARA files.

refs #5367

Changeset: dc6ba8c6c46aec768a2f443db0352b9b38039bfa

comment:20 Changed 8 years ago by Ross Miller

Copoing with changes to ILiveListener interface

refs #5367

Changeset: 1b252e51ef99e1be3cc13e9213d77da606623d6b

comment:21 Changed 8 years ago by Russell Taylor

Removed the compareTimestamp functions from the ADARA packet...

(It wasn't needed and Windows doesn't like struct timespect.) refs #5367

Changeset: 01d4446da517d14547d91fae57182b2cdfbace78

comment:22 Changed 8 years ago by Ross Miller

Initial checkin of live event listener code

Very rough and incomplete. Doesn't actually do anything useful yet, but shouldn't crash the system.

Refs #5367

Changeset: 0f9463b1b3d10a94b54c72c966566418f31fd77e

comment:23 Changed 8 years ago by Ross Miller

Renamed ADARA files from .cc to .cpp to conform to Mantid standards

refs #5367

Changeset: 5a517f86c9f88c4cb6efa8ab51c807ab41605070

comment:24 Changed 8 years ago by Ross Miller

Minor changes from the code review

Code still isn't anywhere near ready for use. refs #5367

Changeset: de6b6f1ae0f5064cc7147df0cc729de973e79dbe

comment:25 Changed 8 years ago by Ross Miller

Converting ADARA source files to Unix line endings

Refs #5367

Changeset: 8fd273deaeda1896f08b6be1a2dc9d3402b5ef82

comment:26 Changed 8 years ago by Ross Miller

Syncing w/ most recent version of ADARA packet parsing code.

Refs #5367

Changeset: 6ba6470d8fc026a3881a8f8f25b9f87183cc6aea

comment:27 Changed 8 years ago by Ross Miller

SNSLiveEventDataListener now mostly implemented. Still needs testing.

Refs #5367

Changeset: 89a31d2201048a97f9127eec77d247042e5936c7

comment:28 Changed 8 years ago by Ross Miller

Added code to get the instrument name from the run status packet...

... and changed how the workspace was initialized. Now using Russell's code to pass XML directly into LoadInstrument. (See #5426)

Refs #5367

Changeset: e21016fdbc492cd10816734bf5dc7869860b048f

comment:29 Changed 8 years ago by Ross Miller

Use new BeamlineInfoPkt class to get the beamline name

Also merged latest ADARA packet parser code from Dave D. Refs #5367

Changeset: af767731012e4332c7d0daa36d8874dffa5c4c92

comment:30 Changed 8 years ago by Ross Miller

Minor changes to how the PulseID and PacketLength values are computed

This is part of Dave D.'s ADARA packet parser code. refs #5367

Changeset: da4a8860cfad012da06f6d2f30c334ee497933b9

comment:31 Changed 8 years ago by Ross Miller

Fixed off-by-one error in the BankedEventPkt parser

refs #5367

Changeset: 381ff8b3035f2344811ffd2a43e47da830718064

comment:32 Changed 8 years ago by Ross Miller

Bug fixes to the SNSLiveEventListener

Bugs found (and fixed) during integration testing: 1) Add code to the destructor to stop the background thread 2) If connect() isn't passed a valid IP address, then assume we're testing/debugging and try to connect to localhost 3) Add checks to prevent us from calling initWorkspace() more than once

Also added some logging for various errors, warnings and debug info refs #5367

Changeset: 420677b30a061e5875dd8bcd1226925572394e68

comment:33 Changed 8 years ago by Ross Miller

Two minor changes: reset the timeout timer on every packet...

...instead of just the client hello packets and add a log message when an invalid pixel id is received. refs #5367

Changeset: 808bd8bf8b64a7fefaf15161ccf104c5111eff00

comment:34 Changed 8 years ago by Ross Miller

Merge branch 'master' into LiveListener

Conflicts:

Code/Mantid/Build/CMake/hdf5-targets-mac.cmake

refs #5367

Changeset: b2302ca44a22209e88295898fca7cf24575ea49c

comment:35 Changed 8 years ago by Ross Miller

Merge branch 'master' into LiveListener

Conflicts:

Code/Mantid/Framework/DataHandling/CMakeLists.txt

refs #5367

Changeset: 7e28c321e2980d1bb3d4fa8db049c4558b386ab5

comment:36 Changed 8 years ago by Ross Miller

Replaced rxPacket() for HelloClient packets with one for Heartbeat

packets. (Because the SMS does not sent out HelloClient packets) refs #5367

Changeset: 97e23d410b5d954b06fb5011b66cb6a5039c7edd

comment:37 Changed 8 years ago by Ross Miller

Replaced gettimeofday() with Poco equivalent...

...and a couple other changes to remove some Linux-specific code. refs #5367

Changeset: 524d283d70e7ae261ce4782251c74d34762eaba7

comment:38 Changed 8 years ago by Ross Miller

Replace Linux-specific code with cross-platform code in ADARA files.

refs #5367

Changeset: dc6ba8c6c46aec768a2f443db0352b9b38039bfa

comment:39 Changed 8 years ago by Ross Miller

Copoing with changes to ILiveListener interface

refs #5367

Changeset: 1b252e51ef99e1be3cc13e9213d77da606623d6b

comment:40 Changed 8 years ago by Russell Taylor

Removed the compareTimestamp functions from the ADARA packet...

(It wasn't needed and Windows doesn't like struct timespect.) refs #5367

Changeset: 01d4446da517d14547d91fae57182b2cdfbace78

comment:41 Changed 8 years ago by Russell Taylor

Re #5367. Don't include SNSLiveEventDataListener in test build (temp)

Needs refactoring to work without relying on a local separate process.

Changeset: 2befccc45e15529e7bb35fe92d6ad37c3e76ea9c

comment:42 Changed 8 years ago by Ross Miller

Changed the logging level of invalid pixel ID's

Was information. now is warning refs #5367

Changeset: dca74804a0f02a93012beddef50a15bf5f089d83

comment:43 Changed 8 years ago by Ross Miller

Change to ADARA protocol

Pixel ID should follow time-of-flight in the event structure - not the other way around.

Refs #5367

Changeset: 301dd126fba72037a8669525915ea9d6d24506cd

comment:44 Changed 8 years ago by Ross Miller

Initial checkin of live event listener code

Very rough and incomplete. Doesn't actually do anything useful yet, but shouldn't crash the system.

Refs #5367

Changeset: 0f9463b1b3d10a94b54c72c966566418f31fd77e

comment:45 Changed 8 years ago by Ross Miller

Renamed ADARA files from .cc to .cpp to conform to Mantid standards

refs #5367

Changeset: 5a517f86c9f88c4cb6efa8ab51c807ab41605070

comment:46 Changed 8 years ago by Ross Miller

Minor changes from the code review

Code still isn't anywhere near ready for use. refs #5367

Changeset: de6b6f1ae0f5064cc7147df0cc729de973e79dbe

comment:47 Changed 8 years ago by Ross Miller

Converting ADARA source files to Unix line endings

Refs #5367

Changeset: 8fd273deaeda1896f08b6be1a2dc9d3402b5ef82

comment:48 Changed 8 years ago by Ross Miller

Syncing w/ most recent version of ADARA packet parsing code.

Refs #5367

Changeset: 6ba6470d8fc026a3881a8f8f25b9f87183cc6aea

comment:49 Changed 8 years ago by Ross Miller

SNSLiveEventDataListener now mostly implemented. Still needs testing.

Refs #5367

Changeset: 89a31d2201048a97f9127eec77d247042e5936c7

comment:50 Changed 8 years ago by Ross Miller

Added code to get the instrument name from the run status packet...

... and changed how the workspace was initialized. Now using Russell's code to pass XML directly into LoadInstrument. (See #5426)

Refs #5367

Changeset: e21016fdbc492cd10816734bf5dc7869860b048f

comment:51 Changed 8 years ago by Ross Miller

Use new BeamlineInfoPkt class to get the beamline name

Also merged latest ADARA packet parser code from Dave D. Refs #5367

Changeset: af767731012e4332c7d0daa36d8874dffa5c4c92

comment:52 Changed 8 years ago by Ross Miller

Minor changes to how the PulseID and PacketLength values are computed

This is part of Dave D.'s ADARA packet parser code. refs #5367

Changeset: da4a8860cfad012da06f6d2f30c334ee497933b9

comment:53 Changed 8 years ago by Ross Miller

Fixed off-by-one error in the BankedEventPkt parser

refs #5367

Changeset: 381ff8b3035f2344811ffd2a43e47da830718064

comment:54 Changed 8 years ago by Ross Miller

Bug fixes to the SNSLiveEventListener

Bugs found (and fixed) during integration testing: 1) Add code to the destructor to stop the background thread 2) If connect() isn't passed a valid IP address, then assume we're testing/debugging and try to connect to localhost 3) Add checks to prevent us from calling initWorkspace() more than once

Also added some logging for various errors, warnings and debug info refs #5367

Changeset: 420677b30a061e5875dd8bcd1226925572394e68

comment:55 Changed 8 years ago by Ross Miller

Two minor changes: reset the timeout timer on every packet...

...instead of just the client hello packets and add a log message when an invalid pixel id is received. refs #5367

Changeset: 808bd8bf8b64a7fefaf15161ccf104c5111eff00

comment:56 Changed 8 years ago by Ross Miller

Merge branch 'master' into LiveListener

Conflicts:

Code/Mantid/Build/CMake/hdf5-targets-mac.cmake

refs #5367

Changeset: b2302ca44a22209e88295898fca7cf24575ea49c

comment:57 Changed 8 years ago by Ross Miller

Merge branch 'master' into LiveListener

Conflicts:

Code/Mantid/Framework/DataHandling/CMakeLists.txt

refs #5367

Changeset: 7e28c321e2980d1bb3d4fa8db049c4558b386ab5

comment:58 Changed 8 years ago by Ross Miller

Replaced rxPacket() for HelloClient packets with one for Heartbeat

packets. (Because the SMS does not sent out HelloClient packets) refs #5367

Changeset: 97e23d410b5d954b06fb5011b66cb6a5039c7edd

comment:59 Changed 8 years ago by Ross Miller

Replaced gettimeofday() with Poco equivalent...

...and a couple other changes to remove some Linux-specific code. refs #5367

Changeset: 524d283d70e7ae261ce4782251c74d34762eaba7

comment:60 Changed 8 years ago by Ross Miller

Replace Linux-specific code with cross-platform code in ADARA files.

refs #5367

Changeset: dc6ba8c6c46aec768a2f443db0352b9b38039bfa

comment:61 Changed 8 years ago by Ross Miller

Copoing with changes to ILiveListener interface

refs #5367

Changeset: 1b252e51ef99e1be3cc13e9213d77da606623d6b

comment:62 Changed 8 years ago by Russell Taylor

Removed the compareTimestamp functions from the ADARA packet...

(It wasn't needed and Windows doesn't like struct timespect.) refs #5367

Changeset: 01d4446da517d14547d91fae57182b2cdfbace78

comment:63 Changed 8 years ago by Russell Taylor

Re #5367. Don't include SNSLiveEventDataListener in test build (temp)

Needs refactoring to work without relying on a local separate process.

Changeset: 2befccc45e15529e7bb35fe92d6ad37c3e76ea9c

comment:64 Changed 8 years ago by Ross Miller

Changed the logging level of invalid pixel ID's

Was information. now is warning refs #5367

Changeset: dca74804a0f02a93012beddef50a15bf5f089d83

comment:65 Changed 8 years ago by Russell Taylor

Re #5367. Add assumed SMS location for HYSPEC to Facilities.xml

Changeset: fa057376c4ac0378430079a2827a075fb1183cb0

comment:66 Changed 8 years ago by Ross Miller

  • Status changed from assigned to accepted

comment:67 Changed 8 years ago by Ross Miller

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:68 Changed 8 years ago by Ross Miller

  • Blocking 5690 added

comment:69 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:70 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

comment:71 Changed 8 years ago by Stuart Campbell

  • Milestone changed from Release 2.2 to Release 2.3

I made a mistake with the version of code I was testing against. It is not important to be completed for this release.

comment:72 Changed 8 years ago by Russell Taylor

Re #5367. Add assumed SMS location for HYSPEC to Facilities.xml

Changeset: fa057376c4ac0378430079a2827a075fb1183cb0

comment:73 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6213

Note: See TracTickets for help on using tickets.