Ticket #5391 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

MaskWorkspaceToCalFile invert

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 2.1.1
Component: Mantid Keywords: PatchCandidate,Released
Cc: Blocked By:
Blocking: Tester: Robert Whitley

Description

MaskWorkspaceToCalFile has property for inversion, but it is not used.

As the 2.1 'stable' release has many aspects of masking broken, it is critical that we get this fixed.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

refs #5391. Inversion now working

Changeset: 3ccf9b8308143077fc596df0f2d173ed35301099

comment:3 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Now works on WISH.

Tester: Should be easy to run the algorithm with Invert set on and then off on a masked workspace and then compare the two *.cal files generated. select and group should be opposite between the two output files.

comment:4 Changed 8 years ago by Owen Arnold

  • Keywords PatchCandidate added

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.1.1

Moved for inclusion in the 2.1.1 patch

comment:6 Changed 8 years ago by Owen Arnold

refs #5391. Inversion now working

Changeset: 3ccf9b8308143077fc596df0f2d173ed35301099

comment:7 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:8 Changed 8 years ago by Owen Arnold

refs #5391. Inversion now working

Changeset: d13c5ebff2487c139f99bc703af9dd369baaae24

comment:9 Changed 8 years ago by Owen Arnold

refs #5391. Inversion now working

Changeset: 3ccf9b8308143077fc596df0f2d173ed35301099

comment:10 Changed 8 years ago by Robert Whitley

  • Status changed from verifying to verify
  • Tester Roman Tolchenov deleted

Taking ticket off Roman

comment:11 Changed 8 years ago by Robert Whitley

  • Status changed from verify to verifying
  • Tester set to Robert Whitley

comment:12 Changed 8 years ago by Robert Whitley

  • Status changed from verifying to closed

Worked with different files, masked them, then saved to cal file with invert selected. The output for these created files were what I expected.

comment:13 Changed 7 years ago by Nick Draper

  • Keywords PatchCandidate,Released added; PatchCandidate removed

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6237

Note: See TracTickets for help on using tickets.