Ticket #5399 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

BoxController::m_numSplit is not initialized

Reported by: Russell Taylor Owned by: Owen Arnold
Priority: minor Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Presumably this has not caused any noticeable problem, but valgrind complains about it not being initialized: 

==25377== Conditional jump or move depends on uninitialised value(s)
==25377==    at 0x5CFAD65: Mantid::API::BoxController::resetMaxNumBoxes() (BoxController.h:451)
==25377==    by 0x5CFAC2B: Mantid::API::BoxController::resetNumBoxes() (BoxController.h:337)
==25377==    by 0x1AD32A49: Mantid::API::BoxController::BoxController(unsigned long) (BoxController.h:45)
==25377==    by 0x1ADB2D4C: Mantid::MDEvents::MDEventWorkspace<Mantid::MDEvents::MDLeanEvent<3ul>, 3ul>::MDEventWorkspace() (MDEventWorkspace.cpp:40)
==25377==    by 0x1AD31F95: Mantid::MDEvents::MDEventFactory::CreateMDWorkspace(unsigned long, std::string const&) (MDEventFactory.cpp:230)
==25377==    by 0x1AC562A8: Mantid::MDEvents::ConvertToDiffractionMDWorkspace::exec() (ConvertToDiffractionMDWorkspace.cpp:446)
==25377==    by 0x5CB707A: Mantid::API::Algorithm::execute() (Algorithm.cpp:541)
==25377== 
==25377== Conditional jump or move depends on uninitialised value(s)
==25377==    at 0x5CFAD65: Mantid::API::BoxController::resetMaxNumBoxes() (BoxController.h:451)
==25377==    by 0x5CFAC2B: Mantid::API::BoxController::resetNumBoxes() (BoxController.h:337)
==25377==    by 0x5CFAB8D: Mantid::API::BoxController::setMaxDepth(unsigned long) (BoxController.h:235)
==25377==    by 0x1AC15E52: Mantid::MDEvents::BoxControllerSettingsAlgorithm::setBoxController(boost::shared_ptr<Mantid::API::BoxController>) (BoxControllerSettingsAlgorithm.cpp:91)
==25377==    by 0x1AC56A23: Mantid::MDEvents::ConvertToDiffractionMDWorkspace::exec() (ConvertToDiffractionMDWorkspace.cpp:472)

I expect it should be initialized to 1, but I'm not certain...

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Owen Arnold

comment:2 Changed 8 years ago by Owen Arnold

refs #5399. Fix issue identified by valgrind

Changeset: 24e311fc4cc7ad6837495b779951cc8b5d26a807

comment:3 Changed 8 years ago by Owen Arnold

  • Status changed from assigned to accepted

comment:4 Changed 8 years ago by Owen Arnold

refs #5399. Fix initialisation order warning

Changeset: d24362be7a8494064860014165c019732f6a562e

comment:5 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: This is a simple fix. It should be clear from the code changes.

comment:6 Changed 8 years ago by Owen Arnold

refs #5399. Fix issue identified by valgrind

Changeset: 24e311fc4cc7ad6837495b779951cc8b5d26a807

comment:7 Changed 8 years ago by Owen Arnold

refs #5399. Fix initialisation order warning

Changeset: d24362be7a8494064860014165c019732f6a562e

comment:8 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:9 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6245

Note: See TracTickets for help on using tickets.