Ticket #5403 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Custom 'unwrap' detector view for side by side viewing of banks.

Reported by: Stuart Campbell Owned by: Roman Tolchenov
Priority: critical Milestone: Release 3.0
Component: MantidPlot Keywords:
Cc: nick.draper@… Blocked By:
Blocking: Tester: Stuart Campbell

Description (last modified by Nick Draper) (diff)

This request has been raised by VISION, but it may be of use for other beam lines.

Basically, they would like an instrument view that will display selected detector banks side by side in N rows by M columns.

The banks themselves just need to be displayed as a 'flat' image, similar to what is seen in the 'normal' unwrap views.

Attachments

vision-unwraped.png (27.7 KB) - added by Stuart Campbell 7 years ago.

Change History

comment:1 Changed 8 years ago by Stuart Campbell

  • Priority changed from major to critical

comment:2 Changed 8 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Stuart Campbell

  • Milestone changed from Release 2.2 to Release 2.3

comment:4 Changed 8 years ago by Stuart Campbell

  • Status changed from accepted to assigned

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:9 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after R2.6

comment:10 Changed 7 years ago by Nick Draper

  • Owner changed from Stuart Campbell to Roman Tolchenov
  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.0

comment:11 Changed 7 years ago by Nick Draper

Another prime example is the SANS instruments at ISIS

comment:12 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Refactored Instrument actor visitors to make them more generic.

Re #5403

Changeset: 18dd3286059ed984a55b092cb55ea0e3a7a6e118

comment:13 Changed 7 years ago by Roman Tolchenov

Added method for finding flat detector assemblies. Re #5403

Changeset: 539c099821aebd2b4102bf812bb564370ee4487e

comment:14 Changed 7 years ago by Roman Tolchenov

Calculation of the rotations for banks. Re #5403

Changeset: 346292959388cab03cfc109fb7b21fcba2e31872

comment:15 Changed 7 years ago by Roman Tolchenov

Spread detectors over the plane so they don't overlap. Re #5403

Changeset: fe56b19b0ada406a1213143b204c3b21bb8262fa

comment:16 Changed 7 years ago by Roman Tolchenov

Calculate detectors visible sizes. Re #5403

Changeset: 1e94d49ff4e5e4bc760ba06d2e1d922d0184f204

comment:17 Changed 7 years ago by Roman Tolchenov

Can show RectangularDetectors. Re #5403

Changeset: a85d439574517808105703c23694aa5c90ed3fe7

comment:18 Changed 7 years ago by Roman Tolchenov

Removed unused code. re #5403

Changeset: 933b8a8e94ebf94d4c9f9f642f957e4ac580fe88

comment:19 Changed 7 years ago by Roman Tolchenov

Inherited all GLActors from QObject to prevent strange crash. Re #5403

Changeset: 0e696c4b91e00db0577901f08796c4526b2bacf9

comment:20 Changed 7 years ago by Roman Tolchenov

Fixed windows compiler warning. Re #5403

Changeset: 38f8e802651c238e29ac655c4a1f630fcf3290ca

comment:21 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

branch feature/5403_side_by_side_unwrap_view

To test open the instrument view and select "Side by side" view type. The new view doesn't work well for all instruments, only for some of them, eg VISION, LOQ.

The view doesn't arrange the banks in rows but radially around a central point. I think this geometry is better for instruments like VISION.

comment:22 Changed 7 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

Changed 7 years ago by Stuart Campbell

comment:23 Changed 7 years ago by Stuart Campbell

I think that this is an excellent solution as a generic view.

The only minor graphical issue I found is that the 'double' banks at 90,180,270 degrees have no gap between them.

comment:24 Changed 7 years ago by Stuart Campbell

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/5403_side_by_side_unwrap_view'

Full changeset: 4a4c3b86f14a8e45d32c31df4dbaa481ec1da1f6

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6249

Note: See TracTickets for help on using tickets.