Ticket #5413 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

QuadEnBackgroundTest overestimates fit accuracy.

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Test results depend on a particular generated random number sequence.

Change History

comment:1 Changed 8 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Roman Tolchenov

Re #5413. Increased tolerance for tested values.

Changeset: 6ff0eb7176e93ddbe36389697cde09279bffaf09

comment:3 Changed 8 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Roman Tolchenov

Re #5413. Increased tolerance for tested values.

Changeset: 6ff0eb7176e93ddbe36389697cde09279bffaf09

comment:5 Changed 8 years ago by Roman Tolchenov

Re #5413. Increased tolerance for tested values.

Changeset: 6ff0eb7176e93ddbe36389697cde09279bffaf09

comment:6 Changed 8 years ago by Russell Taylor

Re #5413. Clear compiler warning.

Changeset: 4c682697db5e1b4ea217cd36d89fc4f33ce6671b

comment:7 Changed 8 years ago by Russell Taylor

Re #5413. Clear compiler warning.

Changeset: 4c682697db5e1b4ea217cd36d89fc4f33ce6671b

comment:8 Changed 8 years ago by Russell Taylor

Re #5413. Clear compiler warning.

Changeset: 4c682697db5e1b4ea217cd36d89fc4f33ce6671b

comment:9 Changed 8 years ago by Russell Taylor

Re #5413. Clear compiler warning.

Changeset: 4c682697db5e1b4ea217cd36d89fc4f33ce6671b

comment:10 Changed 8 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:11 Changed 8 years ago by Russell Taylor

I'm pretty sure this still fails sometimes - I'll try and find an example.

comment:12 Changed 8 years ago by Russell Taylor

I guess it's pretty rare - I have 2 week old emails from the build servers about it, but the builds have dropped off the Jenkins record. A point for a follow-up ticket would be that unit tests shouldn't use random numbers - this was the subject of a skype thread a couple of weeks back.

comment:13 Changed 8 years ago by Anders Markvardsen

  • Status changed from verifying to verify
  • Tester Anders Markvardsen deleted

I may let someone else test this one, in some sense Russell have already done most of this

comment:14 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:15 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

This used to fail all the time, but I haven't seen it fail since the tolerances in the tests were increased.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6259

Note: See TracTickets for help on using tickets.