Ticket #5416 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

in FFT compare input workspace index to number of histograms

Reported by: Jose Borreguero Owned by: Jose Borreguero
Priority: trivial Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

A minor correction in FFT. Change line:

if( iReal >= ysize ) throw std::invalid_argument("Property Real is out of range");

to

if( iReal >= static_cast<int>(inWS->getNumberHistograms()) )throw std::invalid_argument("Property Real is out of range");

Change History

comment:1 Changed 8 years ago by Jose Borreguero

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Jose Borreguero

Refs #5416 compare iReal to getNumberHistograms

modified: FFT.cpp

Changeset: 6b03919f0033f9780f9d39742a4c782ffae20496

comment:3 Changed 8 years ago by Jose Borreguero

Refs #5416 compare iReal to getNumberHistograms

modified: FFT.cpp

Changeset: 6b03919f0033f9780f9d39742a4c782ffae20496

comment:4 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Jose Borreguero

Refs #5416 compare iReal to getNumberHistograms

modified: FFT.cpp

Changeset: 6b03919f0033f9780f9d39742a4c782ffae20496

comment:6 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 8 years ago by Martyn Gigg

Confirmed change makes sense. The comparison before was incorrect.

comment:8 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6262

Note: See TracTickets for help on using tickets.