Ticket #5419 (closed: fixed)
SumNeighbors support more than rectangular detectors
Reported by: | Peter Peterson | Owned by: | Vickie Lynch |
---|---|---|---|
Priority: | major | Milestone: | Release 2.2 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Wenduo Zhou |
Description
The new NOMAD instrument geometry has changed from RectangularDetectors to tubes and so SumNeighbours will no longer work. The particular case that is being used is to sum in y (along the tube) 8 pixels before running CalibrateRectangularDetector, then run SmoothNeighbours on the resulting OffsetsWorkspace for 8 pixels along the tube.
Change History
comment:2 Changed 8 years ago by Vickie Lynch
Refs #5419 SmoothNeighbours matches SumNeighbours for RectDet events
Changeset: 5255a8e201e22aec6ff4a78b7697a45f7b04c195
comment:3 Changed 8 years ago by Vickie Lynch
Refs #5419 SmoothNeighbours test passes
Changeset: 6c34c5b07c57be7190bb1a8c3f6177b7f6063c8b
comment:4 Changed 8 years ago by Vickie Lynch
Refs #5419 Sum even or odd number of pixels
Changeset: 1cb12f9458402c605ee4c88412385868679b5206
comment:5 Changed 8 years ago by Russell Taylor
Re #5419. Clear MSVC compiler warning.
Changeset: 69452b742e70242325e8ac0e80054c9021f71696
comment:6 Changed 8 years ago by Vickie Lynch
Refs #5419 SmoothNeighbours matches SumNeighbours for RectDet events
Changeset: 5255a8e201e22aec6ff4a78b7697a45f7b04c195
comment:7 Changed 8 years ago by Vickie Lynch
Refs #5419 SmoothNeighbours test passes
Changeset: 6c34c5b07c57be7190bb1a8c3f6177b7f6063c8b
comment:8 Changed 8 years ago by Vickie Lynch
Refs #5419 Sum even or odd number of pixels
Changeset: 1cb12f9458402c605ee4c88412385868679b5206
comment:9 Changed 8 years ago by Russell Taylor
Re #5419. Clear MSVC compiler warning.
Changeset: 69452b742e70242325e8ac0e80054c9021f71696
comment:10 Changed 8 years ago by Vickie Lynch
Refs #5419 SmoothNeighbours matches SumNeighbours for RectDet events
Changeset: 5255a8e201e22aec6ff4a78b7697a45f7b04c195
comment:11 Changed 8 years ago by Vickie Lynch
Refs #5419 SmoothNeighbours test passes
Changeset: 6c34c5b07c57be7190bb1a8c3f6177b7f6063c8b
comment:12 Changed 8 years ago by Vickie Lynch
Refs #5419 Sum even or odd number of pixels
Changeset: 1cb12f9458402c605ee4c88412385868679b5206
comment:13 Changed 8 years ago by Russell Taylor
Re #5419. Clear MSVC compiler warning.
Changeset: 69452b742e70242325e8ac0e80054c9021f71696
comment:14 Changed 8 years ago by Vickie Lynch
Refs #5419 SumNeighbours calls SmoothNeighbours
Changeset: d1eaf136c871ed0a4e0a7c98d96fd8cd6885a0bb
comment:15 Changed 8 years ago by Vickie Lynch
Refs #5419 fix new SumNeighbours
Changeset: 1d27da9b427746b1f0e7c5eab5d53724b8767a21
comment:16 Changed 8 years ago by Vickie Lynch
Refs #5419 SumNeighbours calls SmoothNeighbours
Changeset: d1eaf136c871ed0a4e0a7c98d96fd8cd6885a0bb
comment:17 Changed 8 years ago by Vickie Lynch
Refs #5419 fix new SumNeighbours
Changeset: 1d27da9b427746b1f0e7c5eab5d53724b8767a21
comment:18 Changed 8 years ago by Vickie Lynch
Refs #5419 SmoothNeighbours works in calibration
Changeset: 09db11d179860de0414405228eae008d6edcedc3
comment:19 Changed 8 years ago by Vickie Lynch
- Status changed from accepted to verify
- Resolution set to fixed
SNAP calibration from http://www.mantidproject.org/images/c/c5/SNAP_Calibrate.png which uses both SumNeighbours and SmoothNeighbours for rectangular detectors still works. Also CalibrateRectangularDetectors (bad choice of name now) loads the non-rectangular detectors for NOMAD and calls SumNeighbours and SmoothNeighbours for non-rectangular detectors.
comment:20 Changed 8 years ago by Russell Taylor
Re #5419. Clear MSVC compiler warning.
Changeset: 69452b742e70242325e8ac0e80054c9021f71696
comment:21 Changed 8 years ago by Vickie Lynch
Refs #5419 SumNeighbours calls SmoothNeighbours
Changeset: d1eaf136c871ed0a4e0a7c98d96fd8cd6885a0bb
comment:22 Changed 8 years ago by Vickie Lynch
Refs #5419 fix new SumNeighbours
Changeset: 1d27da9b427746b1f0e7c5eab5d53724b8767a21
comment:23 Changed 8 years ago by Vickie Lynch
Refs #5419 SmoothNeighbours works in calibration
Changeset: 09db11d179860de0414405228eae008d6edcedc3
comment:24 Changed 8 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:26 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6265