Ticket #5431 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

unit test for SassenaFFT

Reported by: Jose Borreguero Owned by: Jose Borreguero
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

Test the different features of the algorithm SassenaFFT.

Change History

comment:1 Changed 8 years ago by Jose Borreguero

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Jose Borreguero

Refs #5431 First writing of the unit test for SassenaFFT

Changeset: 95af541948219563a5382d918d9c781b8181bb00

comment:3 Changed 8 years ago by Jose Borreguero

Refs #5431 First writing of the unit test for SassenaFFT

Changeset: 95af541948219563a5382d918d9c781b8181bb00

comment:4 Changed 8 years ago by Jose Borreguero

Refs #5431 First writing of the unit test for SassenaFFT

Changeset: 95af541948219563a5382d918d9c781b8181bb00

comment:5 Changed 8 years ago by Jose Borreguero

Refs #5431 finished test_ZeroImaginary

modified: SassenaFFTTest.h

Changeset: 25ae97d2050069192f637f5f52a9e92c30b83b83

comment:6 Changed 8 years ago by Jose Borreguero

Refs #5431 uncomment build line in CMakeList file

modified: CMakeLists.txt

Changeset: 406892758d6accf986cdd0e52897403ace3382a3

comment:7 Changed 8 years ago by Jose Borreguero

Refs #5431 added file

Changeset: 9eb221c0c2fe390176a51eab720f633722abdb75

comment:8 Changed 8 years ago by Jose Borreguero

Refs #5431 Build error for std::accumulate

modified: CMakeLists.txt

Changeset: cfacb8586b96c20c4d02347f25afae13d7c82a64

comment:9 Changed 8 years ago by Jose Borreguero

Refs #5431 Replace std::accumulate for iterator

modified: CMakeLists.txt modified: test/SassenaFFTTest.h

Changeset: f81245ba6132d7d5c2fd51f299507879c0d32b85

comment:10 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 8 years ago by Jose Borreguero

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:12 Changed 8 years ago by Jose Borreguero

Test sometimes fails on isis_snowleopard. A comparison between a successful and failed test shows that the failed build did not "Scanning dependencies of target AlgorithmsTest"

FAILED: 

13/758 Test #503: AlgorithmsTest_SassenaFFTTest .............................***Failed   17.06 sec
ConfigService-[Warning] Required properties path "/Users/mantidlog/Jenkins/workspace/isis_snowleopard/build/bin/pvplugins/" in the "pvplugins.directory" variable does not exist.]
ConfigService-[Notice] ParaView is not available
Running 2 tests.SassenaFFT-[Notice] SassenaFFT started
Segmentation fault

SUCCESSFULL: 

Scanning dependencies of target AlgorithmsTest
[ 87%] Building CXX object Framework/Algorithms/CMakeFiles/AlgorithmsTest.dir/SassenaFFTTest.cpp.o
Linking CXX executable ../../bin/AlgorithmsTest
636/758 Test #503: AlgorithmsTest_SassenaFFTTest .............................   Passed    1.92 sec

comment:13 Changed 8 years ago by Jose Borreguero

  • Status changed from reopened to accepted

comment:14 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

Apparently, the reason for the failed test was an error in scanning dependencies outside the Algorithm package due to a commit that updated those out-package dependencies.

comment:15 Changed 8 years ago by Jose Borreguero

Refs #5431 finished test_ZeroImaginary

modified: SassenaFFTTest.h

Changeset: 25ae97d2050069192f637f5f52a9e92c30b83b83

comment:16 Changed 8 years ago by Jose Borreguero

Refs #5431 uncomment build line in CMakeList file

modified: CMakeLists.txt

Changeset: 406892758d6accf986cdd0e52897403ace3382a3

comment:17 Changed 8 years ago by Jose Borreguero

Refs #5431 added file

Changeset: 9eb221c0c2fe390176a51eab720f633722abdb75

comment:18 Changed 8 years ago by Jose Borreguero

Refs #5431 Build error for std::accumulate

modified: CMakeLists.txt

Changeset: cfacb8586b96c20c4d02347f25afae13d7c82a64

comment:19 Changed 8 years ago by Jose Borreguero

Refs #5431 Replace std::accumulate for iterator

modified: CMakeLists.txt modified: test/SassenaFFTTest.h

Changeset: f81245ba6132d7d5c2fd51f299507879c0d32b85

comment:20 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:21 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:22 Changed 8 years ago by Jose Borreguero

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Milestone changed from Release 2.2 to Release 2.3

comment:23 Changed 8 years ago by Jose Borreguero

  • Milestone changed from Release 2.3 to Release 2.4

comment:24 Changed 8 years ago by Jose Borreguero

Refs #5431 replace obsolete executeAsSubalgorithm

modified: Algorithms/src/SassenaFFT.cpp

Changeset: c9bf56081486e494ce83a5d42437d23ad44355f0

comment:25 Changed 8 years ago by Jose Borreguero

Refs #5431 don't run the test for now

modified: Mantid/Framework/Algorithms/CMakeLists.txt

Changeset: e8d5b22fee5e26b9762a8bc2ce67cfe1ae4a6344

comment:26 Changed 8 years ago by Jose Borreguero

Refs #5431 replace obsolete executeAsSubalgorithm

modified: Algorithms/src/SassenaFFT.cpp

Changeset: c63b31315b249b656944cd232040fc26d7859e18

comment:27 Changed 8 years ago by Jose Borreguero

Refs #5431 don't run the test for now

modified: Mantid/Framework/Algorithms/CMakeLists.txt

Changeset: 075f82686d884b7e70f5f2b744d448c259664b7d

comment:28 Changed 8 years ago by Jose Borreguero

Refs #5431 Fix unit conversion error

modified: SassenaFFT.h modified: SassenaFFT.cpp modified: SassenaFFTTest.h

Changeset: f0230220453bb0c8f69b7b8eb2b00c185ee8576e

comment:29 Changed 8 years ago by Jose Borreguero

Refs #5431 re-enable compilation of the test

modified: CMakeLists.txt

Changeset: a7b56b7d2e02359d5429f4bb2d4f843be2dd858a

comment:30 Changed 8 years ago by Jose Borreguero

REfs #5431 again prevent test from running

modified: ../../CMakeLists.txt

Changeset: bb9a633580f4e1ac3c1e38d0275a8bbee8cd0311

comment:31 Changed 8 years ago by Jose Borreguero

Refs #5431 Properly remove the detailed balance condition

modified: SassenaFFT.cpp modified: SassenaFFTTest.h

Changeset: 85dd55a92dacc3a09418014519383260ee10d297

comment:32 Changed 8 years ago by Jose Borreguero

Refs #5431 Re-enable the test, and hope for the best :)

modified: CMakeLists.txt

Changeset: 885311bcfc15e6f1cf1ec3263bb1d09577cdc655

comment:33 Changed 8 years ago by Jose Borreguero

  • Status changed from reopened to accepted

comment:34 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:35 Changed 8 years ago by Jose Borreguero

Refs #5431 Fix unit conversion error

modified: SassenaFFT.h modified: SassenaFFT.cpp modified: SassenaFFTTest.h

Changeset: c95f473b56cd4b6c323fcaf1902627548163932d

comment:36 Changed 8 years ago by Jose Borreguero

Refs #5431 re-enable compilation of the test

modified: CMakeLists.txt

Changeset: cb45282535b170aa13befe99ba3efd848fc2e654

comment:37 Changed 8 years ago by Jose Borreguero

REfs #5431 again prevent test from running

modified: ../../CMakeLists.txt

Changeset: 84b4d7e9f9e81d232f131a023289a6d3cca22f14

comment:38 Changed 8 years ago by Jose Borreguero

Refs #5431 Properly remove the detailed balance condition

modified: SassenaFFT.cpp modified: SassenaFFTTest.h

Changeset: 84c768ff11a494a1878c7eeb8a95f6b358201177

comment:39 Changed 8 years ago by Jose Borreguero

Refs #5431 Re-enable the test, and hope for the best :)

modified: CMakeLists.txt

Changeset: c29497fec091c1df490784077d101ab9e26541c6

comment:40 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester changed from Wenduo Zhou to Stuart Campbell

comment:41 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Unit test seems to work.

comment:42 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6277

Note: See TracTickets for help on using tickets.