Ticket #5461 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Fix IkedaCarpenterPVTest on OS X

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

The IkedaCarpenterPVTest fails on the Mac. It was disabled but never reenabled. In commit ​https://github.com/mantidproject/mantid/commit/cafbd2eb53139739e9057dd92ba7d067317db4e9 the test was disabled for OS X only but it needs to be fixed.

Change History

comment:1 Changed 8 years ago by Russell Taylor

Note that this test passed perfectly happily on the ORNL Mac build, and indeed on my mac. The most obvious difference that I can think of is the compiler version (though the hardware also differs). The ISIS buildserver is on version 12.0.2 / composerxe-2011.2.142 of the Intel compiler, whereas the SNS buildserver is on 12.1.3 / composer_xe_2011_sp1.9.289 and I am on 12.1.4 / composer_xe_2011_sp1.10.328.

So upgrading the compiler version on mantids-imac may be the first thing to try.

comment:2 Changed 8 years ago by Martyn Gigg

Ah okay, I hadn't spotted that. I'm downloading the updated version now and I'll try it out tomorrow.

comment:3 Changed 8 years ago by Martyn Gigg

Enable IkedaCarpenterPVTest on OS X. Refs #5461

Check if compiler upgrade has solved the problem.

Changeset: e2bf4fb693b0eb0bb16abe5d30506c6f742d37a7

comment:4 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted
  • Owner changed from Roman Tolchenov to Martyn Gigg

comment:5 Changed 8 years ago by Martyn Gigg

A compiler upgrade seems to have done the trick.

comment:6 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 8 years ago by Russell Taylor

Re #5013. Re-introduce body of AbragamTest.

It should be fine on all OSX builds now, following upgrade of Intel compiler on ISIS buildserver (see #5461).

Changeset: 53f24740d9c3884c41c2e6139f89d187d5a36d22

comment:8 Changed 8 years ago by Martyn Gigg

Enable IkedaCarpenterPVTest on OS X. Refs #5461

Check if compiler upgrade has solved the problem.

Changeset: e2bf4fb693b0eb0bb16abe5d30506c6f742d37a7

comment:9 Changed 8 years ago by Russell Taylor

Re #5013. Re-introduce body of AbragamTest.

It should be fine on all OSX builds now, following upgrade of Intel compiler on ISIS buildserver (see #5461).

Changeset: 53f24740d9c3884c41c2e6139f89d187d5a36d22

comment:10 Changed 8 years ago by Martyn Gigg

Enable IkedaCarpenterPVTest on OS X. Refs #5461

Check if compiler upgrade has solved the problem.

Changeset: e2bf4fb693b0eb0bb16abe5d30506c6f742d37a7

comment:11 Changed 8 years ago by Russell Taylor

Re #5013. Re-introduce body of AbragamTest.

It should be fine on all OSX builds now, following upgrade of Intel compiler on ISIS buildserver (see #5461).

Changeset: 53f24740d9c3884c41c2e6139f89d187d5a36d22

comment:12 Changed 8 years ago by Russell Taylor

Re #5013. Re-introduce body of AbragamTest.

It should be fine on all OSX builds now, following upgrade of Intel compiler on ISIS buildserver (see #5461).

Changeset: 53f24740d9c3884c41c2e6139f89d187d5a36d22

comment:13 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:14 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

test is running and passing on the build server.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6307

Note: See TracTickets for help on using tickets.