Ticket #5467 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Reflectometry Spectra Identification

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

The ISIS reflectometry group have a logical process layed out, which allows them to identify the channels corresponding to the reflected and transmission lines. This is a useful step as part of their wider reduction workflow.

On inspection, most of this can already be achieved using existing algorithms + a bit of numpy manipulation. Would therfore be best to put this together as a PythonAlgorithm.

Change History

comment:1 Changed 8 years ago by Owen Arnold

The current reduction workflow requires that users provide hard-coded values for the spectrum numbers corresponding to these lines, so this addition should enable much better automation of their reduction workflow.

comment:2 Changed 8 years ago by Owen Arnold

refs #5467. Working algorithm

Changeset: 080d7b48c7a4601eeb2eaa3e5d7309b57a07c489

comment:3 Changed 8 years ago by Owen Arnold

refs #5467. Docs and wiki docs

Changeset: b567419bbe84414cbee24b38654c55d568d3d665

comment:4 Changed 8 years ago by Owen Arnold

refs #5467. Test for python algorithm

Changeset: 228af0f8db4f75a700cceb144cf3f3fd84cced19

comment:5 Changed 8 years ago by Owen Arnold

refs #5467. Fabricate input workspaces for test.

Changeset: 4baf7a404bb2c5413059907056631ac392b26af1

comment:6 Changed 8 years ago by Owen Arnold

refs #5467. No file access now required for tests.

Changeset: d2e002f20d2779a3c5fae3b30e2707278cac2814

comment:7 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:8 Changed 8 years ago by Owen Arnold

refs #5467 reflected and transmission switch correction

Changeset: d1aae544ee1430c182937fbfb12880c737bdc500

comment:9 Changed 8 years ago by Owen Arnold

refs #5458 #5467. Update system test

Changeset: 165c3da535845d8c6088b6846f91148e14124a07

comment:10 Changed 8 years ago by Owen Arnold

refs #5467. Working algorithm

Changeset: 080d7b48c7a4601eeb2eaa3e5d7309b57a07c489

comment:11 Changed 8 years ago by Owen Arnold

refs #5467. Docs and wiki docs

Changeset: b567419bbe84414cbee24b38654c55d568d3d665

comment:12 Changed 8 years ago by Owen Arnold

refs #5467. Test for python algorithm

Changeset: 228af0f8db4f75a700cceb144cf3f3fd84cced19

comment:13 Changed 8 years ago by Owen Arnold

refs #5467. Fabricate input workspaces for test.

Changeset: 4baf7a404bb2c5413059907056631ac392b26af1

comment:14 Changed 8 years ago by Owen Arnold

refs #5467. No file access now required for tests.

Changeset: d2e002f20d2779a3c5fae3b30e2707278cac2814

comment:15 Changed 8 years ago by Owen Arnold

refs #5467 reflected and transmission switch correction

Changeset: d1aae544ee1430c182937fbfb12880c737bdc500

comment:16 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: The unit tests are the best place to identify this working. If required, I can also provide a workspace on which this algorithm can be executed.

comment:17 Changed 8 years ago by Owen Arnold

refs #5467. Working algorithm

Changeset: 080d7b48c7a4601eeb2eaa3e5d7309b57a07c489

comment:18 Changed 8 years ago by Owen Arnold

refs #5467. Docs and wiki docs

Changeset: b567419bbe84414cbee24b38654c55d568d3d665

comment:19 Changed 8 years ago by Owen Arnold

refs #5467. Test for python algorithm

Changeset: 228af0f8db4f75a700cceb144cf3f3fd84cced19

comment:20 Changed 8 years ago by Owen Arnold

refs #5467. Fabricate input workspaces for test.

Changeset: 4baf7a404bb2c5413059907056631ac392b26af1

comment:21 Changed 8 years ago by Owen Arnold

refs #5467. No file access now required for tests.

Changeset: d2e002f20d2779a3c5fae3b30e2707278cac2814

comment:22 Changed 8 years ago by Owen Arnold

refs #5467 reflected and transmission switch correction

Changeset: d1aae544ee1430c182937fbfb12880c737bdc500

comment:23 Changed 8 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:24 Changed 8 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Unit tests test for the case of 0, 1, 2 and 3 peaks and passes

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6313

Note: See TracTickets for help on using tickets.