Ticket #5545 (assigned)
Make the default peak radius infinite and reduce it only when needed
| Reported by: | Roman Tolchenov | Owned by: | Roman Tolchenov |
|---|---|---|---|
| Priority: | major | Milestone: | Backlog |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: |
Description (last modified by Roman Tolchenov) (diff)
The PeakFunction has a default and quite small 'peak radius' - a cut-off distance for the peak wings. It is a good thing for algorithms such as FindPeaks but can be a problem for a user who is unfamiliar with it.
My suggestion is to make the default very large and reduce it when necessary.
Attachments
Change History
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:3 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:6 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:7 Changed 7 years ago by Nick Draper
- Status changed from new to infoneeded
Please assess if ticket is still valid and add a description to the ticket
comment:8 Changed 7 years ago by Roman Tolchenov
- Status changed from infoneeded to new
- Description modified (diff)
comment:9 Changed 7 years ago by Nick Draper
- Status changed from new to infoneeded
What effect would this have on the creating and adjusting a peak using the GUI.
The Very Large comment is slightly concerning.
Rather than a set default could we not try to assess the HWHM using a simple walk out from the centre of the peak?
comment:10 Changed 7 years ago by Roman Tolchenov
- This won't have any negative effect on the GUI.
- Very large means that practically there is no cut-off and no loss of accuracy.
- The dynamic cut-off is possible but it will be slower than the fixed value or each peak will have to implement the walk.
- Maybe this 'radius' should become an attribute? This would make it more visible and flexible.
comment:11 Changed 6 years ago by Roman Tolchenov
- Status changed from infoneeded to new
- Milestone changed from Backlog to Release 3.3
comment:13 Changed 6 years ago by Nick Draper
Moved to the backlog at the code freeze of R3.3
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6391
Moved at the end of release 2.2