Ticket #5553 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Modify convert to MD code according to Martyn's recommndations.

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Nick Draper

Description


Change History

comment:1 Changed 8 years ago by Alex Buts

refs #5553 Headers modified in accordance with Martyn;'s suggestions

Changeset: 843b6968e8ab029538e52875b745b41317729d87

comment:2 Changed 8 years ago by Alex Buts

refs #5553 This mainly fixes it

Changeset: 10bcd2b9530963c8a71e265cc7292788121b963c

comment:3 Changed 8 years ago by Alex Buts

refs #5553 fixing unit tests

Changeset: 9bc3673d00c7bd700e03f4cb746f265b649bffe0

comment:4 Changed 8 years ago by Alex Buts

  • Status changed from new to accepted

comment:5 Changed 8 years ago by Alex Buts

  • Blocked By 5656 added

(In #5656) This ticket is the extension of ticket 5553 so should be treated together.

comment:6 Changed 8 years ago by Alex Buts

  • Cc martyn.gigg@… added

comment:7 Changed 8 years ago by Alex Buts

refs #5553 Headers modified in accordance with Martyn;'s suggestions

Changeset: 843b6968e8ab029538e52875b745b41317729d87

comment:8 Changed 8 years ago by Alex Buts

refs #5553 This mainly fixes it

Changeset: 10bcd2b9530963c8a71e265cc7292788121b963c

comment:9 Changed 8 years ago by Alex Buts

refs #5553 fixing unit tests

Changeset: 9bc3673d00c7bd700e03f4cb746f265b649bffe0

comment:10 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Blocked By 5656 removed

These changes are mainly complete except spaces between equal sing.

Bearing in mind ticket #5656 and appalling performance of this code, which will request substantial changes anyway, I am closing this ticket and transferring remain change to ticket #5656

comment:11 Changed 8 years ago by Alex Buts

refs #5553 trying to revert changes which cause tests to fail

Changeset: 32081fdff2fec6fc95e9c527173ae3d41036a87d

comment:12 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:13 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted
  • Milestone changed from Release 2.2 to Release 2.3

I made quite a few more suggestions that have been performed here. There are many more formatting issues that have not been sorted out. There were areas with shared_ptrs as if(shared_ptr.get()) that needed to be removed.

Since the code may have to change I am pushing this back to the next release

comment:14 Changed 8 years ago by Alex Buts

refs #5553 trying to revert changes which cause tests to fail

Changeset: 32081fdff2fec6fc95e9c527173ae3d41036a87d

comment:15 Changed 8 years ago by Alex Buts

refs #5553 Got read of all !shered_ptt.get() operations

(hopefully)

Changeset: 3feeda0edaf7afb638be33475440234a570b2ffc

comment:16 Changed 8 years ago by Alex Buts

refs #5553 minor changes -- couple of more brackets discovered.

Changeset: 69634b639651d1af6810a7fead15ded724eeb546

comment:17 Changed 8 years ago by Alex Buts

  • Status changed from reopened to accepted

hope this is all on this ticket except the stuff, which went to #5656

comment:18 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:19 Changed 8 years ago by Russell Taylor

Re #5553. Compiler warning.

Changeset: 32927f891bd2c0b5e4abd96dfc80743b835e0d27

comment:20 Changed 8 years ago by Alex Buts

To testers: If there are some remaining issues found on this ticket, they should be addressed through duplicate(and wider) ticket #5656

comment:21 Changed 8 years ago by Alex Buts

refs #5553 Got read of all !shered_ptt.get() operations

(hopefully)

Changeset: 3feeda0edaf7afb638be33475440234a570b2ffc

comment:22 Changed 8 years ago by Alex Buts

refs #5553 minor changes -- couple of more brackets discovered.

Changeset: 69634b639651d1af6810a7fead15ded724eeb546

comment:23 Changed 8 years ago by Russell Taylor

Re #5553. Compiler warning.

Changeset: 32927f891bd2c0b5e4abd96dfc80743b835e0d27

comment:24 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester changed from Martyn Gigg to Nick Draper

accepted

comment:25 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6399

Note: See TracTickets for help on using tickets.