Ticket #5583 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

EQSANSLoad: fix problem with TOF filtering

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

A recent change made to process data loaded by LoadEventNexus cause a problem loading data without performing the EQSANS TOF correction (as used by LENS SANS).

The default TOF cuts (high/low) were set to zero, but the check for filtering was done with isEmpty(). That cause the algorithm to filter out all the events when no TOF min/max were set.

Fix that and add a system test for loading the data without TOF correction while leaving TOF min/max empty.

Change History

comment:1 Changed 8 years ago by Mathieu Doucet

Re #5583 Fix problem with TOF cuts

Changeset: fb6b5586fcb4267d32dc8e5ff4560fb9501a54eb

comment:2 Changed 8 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

Fixed offending code...

comment:4 Changed 8 years ago by Mathieu Doucet

Re #5583 Fix problem with TOF cuts

Changeset: fb6b5586fcb4267d32dc8e5ff4560fb9501a54eb

comment:5 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

The code changes are commensurate with the fixing the issue.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6429

Note: See TracTickets for help on using tickets.