Ticket #5588 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Convert EQSANS Q resolution to use histo

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The TOF SANS resolution calculation is very slow because it deals with every single event separately. There is no real reason to do that. Modify TOFSANSResolution to use histograms instead of dealing with every event. Add proper system tests.

Change History

comment:1 Changed 8 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Mathieu Doucet

Re #5588 Major speed-up of Q resolution calculation

Changeset: 96453b7cff594b6f4d2ff911cb355ee234b4928f

comment:3 Changed 8 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

Factor 10 speed-up with the last commit for a workspace of about 500,000 events. To test, check that it runs and that the system tests in EQSANSDQOutput pass.

comment:4 Changed 8 years ago by Mathieu Doucet

Re #5588 System test for Q resolution calculation.

Changeset: 6d29cf3f439fb1f9feaf9771f47c6dd54cec07b3

comment:5 Changed 8 years ago by Mathieu Doucet

Re #5588 Try to fix system test problem on Windows.

Changeset: 666a12364e0408900e2c0815976f14cdcbda6383

comment:6 Changed 8 years ago by Mathieu Doucet

Re #5588 Add system test for efficiency computation

Changeset: bf3769f517882fced2093f7a9db0318ba51494fc

comment:7 Changed 8 years ago by Mathieu Doucet

Re #5588 Turn off option to keep events to the end

Changeset: d15f7adb46784cd4e118210bcdb1b56e5177ffe0

comment:8 Changed 8 years ago by Mathieu Doucet

Re #5588 Print more info on sys test failure

Changeset: 4f91eed486529d60d60e040fd6be5934d86d504a

comment:9 Changed 8 years ago by Mathieu Doucet

Re #5588 Ensure events are used on sys test

Changeset: b0fa5d13b37cf53a36771e48fb6bfbab7ae4dd6b

comment:10 Changed 8 years ago by Mathieu Doucet

Re #5588 Fix problems with implementation

Changeset: d53dc62f5569f1b6f65d27fa0934763109787b1a

comment:11 Changed 8 years ago by Mathieu Doucet

Re #5588 Major speed-up of Q resolution calculation

Changeset: 96453b7cff594b6f4d2ff911cb355ee234b4928f

comment:12 Changed 8 years ago by Mathieu Doucet

Re #5588 Turn off option to keep events to the end

Changeset: d15f7adb46784cd4e118210bcdb1b56e5177ffe0

comment:13 Changed 8 years ago by Mathieu Doucet

Re #5588 Fix problems with implementation

Changeset: d53dc62f5569f1b6f65d27fa0934763109787b1a

comment:14 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:15 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

Missing a wiki page and unit test, which would have helped guide testing. System tests are passing.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6434

Note: See TracTickets for help on using tickets.