Ticket #5590 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

[IDA] Support "Refresh List" button a la S(Q, w)

Reported by: Peter Parker Owned by: Samuel Jackson
Priority: major Milestone: Release 2.6
Component: Indirect Inelastic Keywords: IDA
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Samuel Jackson) (diff)

In the S(Q, w) tab of the C2E interface, there is now a "Refresh List" button which updates the list of workspaces available for the user to select from.

Implement this in the tabs of IDA that allow a user to select a workspace as input.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:2 Changed 8 years ago by Peter Parker

  • Keywords IDA added

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:4 Changed 8 years ago by Dereck Kachere

  • Owner changed from Peter Parker to Dereck Kachere
  • Status changed from new to assigned

comment:5 Changed 8 years ago by Dereck Kachere

  • Milestone changed from Release 2.4 to Release 2.5

comment:6 Changed 7 years ago by Dereck Kachere

  • Cc spencer.howells@… added

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:10 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress
  • Owner changed from Dereck Kachere to Samuel Jackson
  • Description modified (diff)

comment:11 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Indirect Inelastic

comment:12 Changed 7 years ago by Samuel Jackson

Updated CovertToEnergy interface to use Workspace Selector.

Removed the combo box implementation and refresh button.

Refs #5590

Changeset: 51c0052a2f67d7613aec9b3a81f500c163d8db92

comment:13 Changed 7 years ago by Samuel Jackson

Updating validation for CtoE interface.

Refs #5590

Changeset: 9eae7515996d72f5bd7efd05f39008e5c59fd4fb

comment:14 Changed 7 years ago by Samuel Jackson

Chnaged C2E SofQ tab and IDA interface to use workspace selectors.

Refs #5590

Changeset: 660f9748130615702b1fe122ad6ff8443478fe4c

comment:15 Changed 7 years ago by Samuel Jackson

Miss spelt name of Qt widget.

Refs #5590

Changeset: e211abb50e4974eb533992a6c5decec48ebc4dad

comment:16 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test:

In Convert To Energy interface:

  • Select an instrument (e.g. IRIS)
  • Select the S of Q tab.
  • Change input type to Workspace
  • Load any nexus file. The list of available workspaces should automatically update.

In Indirect Data Analysis interface:

  • Check the following tabs do the same as the above
    • Fury
    • FuryFit
    • ConvFit
    • Calculate Corrections
    • Apply Corrections (x2)

comment:17 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:18 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Fixed merge conflict with another branch I was working on.

Merge commit '184fc6adecdf01bad218c036783e035970f7c9fe' into feature/5590_IDA_support_workspace_refresh

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui

Refs #5590

Changeset: 688a3316aa2564f47244c5deb4c42b54ad262609

comment:19 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:20 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:21 Changed 7 years ago by Jay Rainey

Failed: Convert to energy interface does not update workspace dropdown with workspaces when closed and reopened.

comment:22 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:23 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Adding workspace selector refresh on interface instantiation.

Refs #5590

Changeset: a8c5dd9ab3a8cc8b2d37112c05258bf129ebb750

comment:24 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:25 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying

comment:26 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/5590_IDA_support_workspace_refresh'

comment:27 Changed 7 years ago by Jay Rainey

Testing

  • Testing on Ubuntu 12.4.
  • Convert to energy interface refreshes as expected.
  • All tabs in Indirect Data Analysis now refresh when a data file is loaded..

Code review

  • Clean and consistent code.
  • No visible bugs/problems.

comment:28 Changed 7 years ago by Samuel Jackson

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:29 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Added support for rename and clear workspace events.

Added call to refresh in workspace selector constructor to refresh on init. Removed calls to refresh in individual interfaces.

Refs #5590

Changeset: 3bb8cb8886e7029468c50093e1807f6f215d3b56

comment:30 Changed 7 years ago by Samuel Jackson

Re-adding filters for workspace selectors.

Refs #5590

Changeset: a10f39b939128a216a28f06fa4dd716e2888fcaa

comment:31 Changed 7 years ago by Samuel Jackson

Changing suffix on C2E interface.

Refs #5590

Changeset: 46e23a853f271ebbabb2c6febc7ed4334a986dbe

comment:32 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

Updated workspace selector to handle both rename and clear events.

To Test:

As above, but also check that the workspace selectors are updated when running algorithms that use rename and clear facilities.

Also check that each of the workspace selectors in the IDA interface and the C2E SofQ tab on show files with the following extensions:

  • Fury, ConvFit have *_res & *_sqw
  • FuryFit has *_iqt
  • CalcCorr, ApplyCorr have *_res
  • SofQW should be *_red

comment:33 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Jay Rainey to Martyn Gigg

comment:34 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/5590_IDA_support_workspace_refresh'

comment:35 Changed 7 years ago by Samuel Jackson

Extension corrections from Spencer.

Refs #5590

Changeset: 1674edcbcb00b6868fbdde896517e61e2a7ad25c

comment:36 Changed 7 years ago by Samuel Jackson

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:37 Changed 7 years ago by Samuel Jackson

Correction to testing information. Extensions should be the following:

S(Q,w) should be *_red FuryFit should be *_iqt ConvFit, CalcCorr & ApplyCorr should be *_red

comment:38 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:39 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying

comment:40 Changed 7 years ago by Samuel Jackson

Better workspace renaming in workspace selector.

Refs #5590

Changeset: abaa37cc4721ef481ddc5bc1da89663dccfbc1a1

comment:41 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/5590_IDA_support_workspace_refresh'

comment:42 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6436

Note: See TracTickets for help on using tickets.