Ticket #5601 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Update CRISP IDF to get logvalue equation working

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: minor Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Jose Borreguero

Description


Change History

comment:1 Changed 8 years ago by Owen Arnold

The following script proves that the theta calculation in the CRISP IDF isn't working. 

Load(Filename='CSP90394.raw',OutputWorkspace='CSP90394')

def getPos(ws):
        return ws.getInstrument().getComponentByName('point-detector').getPos()
        
z1ws = mtd['CSP90394']
print getPos(z1ws)

The output should be [12.113, 0, 0.390167], but it's [12.113, 0, 0.0]

comment:2 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted
  • Owner set to Owen Arnold

comment:3 Changed 8 years ago by Owen Arnold

Turns out that the names of the logs are case-sensitive.

comment:4 Changed 8 years ago by Owen Arnold

refs #5601 change theta to lower

Changeset: c0f2fb3e3b9d157498d5983f05e9ad51bbacd2ac

comment:5 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Owen Arnold

refs #5601. Fix failing test after rename

Changeset: 8beb8c4f0dbadb1b1a70bc5ff7541c33bac16159

comment:7 Changed 8 years ago by Owen Arnold

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:8 Changed 8 years ago by Owen Arnold

  • Status changed from reopened to accepted

comment:9 Changed 8 years ago by Owen Arnold

refs #5601. move z-theta calculation into param file

Changeset: f6149ba2dc1636357a510c0eb2dac9f42956dbb4

comment:10 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: You can verify this ticket by running the script in the description. Also, some of the unit tests check the CRISP IDF file, and these are passing.

comment:11 Changed 8 years ago by Owen Arnold

refs #5601 change theta to lower

Changeset: c0f2fb3e3b9d157498d5983f05e9ad51bbacd2ac

comment:12 Changed 8 years ago by Owen Arnold

refs #5601. Fix failing test after rename

Changeset: 8beb8c4f0dbadb1b1a70bc5ff7541c33bac16159

comment:13 Changed 8 years ago by Owen Arnold

refs #5601. move z-theta calculation into param file

Changeset: f6149ba2dc1636357a510c0eb2dac9f42956dbb4

comment:14 Changed 8 years ago by Jose Borreguero

  • Status changed from verify to verifying
  • Tester set to Jose Borreguero

comment:15 Changed 8 years ago by Jose Borreguero

  • Status changed from verifying to closed

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6447

Note: See TracTickets for help on using tickets.