Ticket #5613 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

More information saved in SingleCrystalPeakTable

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Fill in missing columns of information from selecting peaks using Single crystal peak pick from Show Instrument.

Change History

comment:1 Changed 8 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Vickie Lynch

Refs #5613 add BinCount

Changeset: 6ea5fe2c127d921730d1e93e0a9c233ea5b1f3d1

comment:3 Changed 8 years ago by Vickie Lynch

Refs #5613 add RunNumber

Changeset: 4d051ea46741a15e94a8e8ac98f100395c0d91dc

comment:4 Changed 8 years ago by Vickie Lynch

Refs #5613 add intensity

Changeset: fa482c55a2435b1d3ca4fe7bb68005a4381370e0

comment:5 Changed 8 years ago by Vickie Lynch

Refs #5613 add BinCount

Changeset: 6ea5fe2c127d921730d1e93e0a9c233ea5b1f3d1

comment:6 Changed 8 years ago by Vickie Lynch

Refs #5613 add RunNumber

Changeset: 4d051ea46741a15e94a8e8ac98f100395c0d91dc

comment:7 Changed 8 years ago by Vickie Lynch

Refs #5613 add intensity

Changeset: fa482c55a2435b1d3ca4fe7bb68005a4381370e0

comment:8 Changed 8 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

To test, use the select single crystal peak tool from the instrument pick menu on binned data. Select peak in Plotting detector spectra plot and then open SingleCrystalPeakTable.

comment:9 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:10 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Line 777 in InstrumentWindowPickTab.cpp leads to a seg fault for non TOF workspaces

comment:11 Changed 8 years ago by Vickie Lynch

  • Status changed from reopened to accepted

comment:12 Changed 8 years ago by Vickie Lynch

Refs #5613 deleted line 777

Changeset: f267bb6c4ad24c5dc4e4f8e83718ad9b11bdb681

comment:13 Changed 8 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

CNCS non-TOF workspace doesn't crash now

comment:14 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying

comment:15 Changed 8 years ago by Vickie Lynch

Refs #5613 fixed for CNCS non-TOF

Changeset: 3ff0eac2d38f3aba314879d0f145c34ff2ca7e94

comment:16 Changed 8 years ago by Vickie Lynch

Hi Andrei, The dialog to find m_efixed and m_delta for elastic just below the lines I added looks wrong to me. Also why does the indirect conversion work without getting m_efixed? Your example script works now.

comment:17 Changed 8 years ago by Vickie Lynch

Refs #5613 fixed elastic and indirect for non-TOF

Changeset: aa61b61fcef0a8b40376e8ca0359959159feff01

comment:18 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:19 Changed 8 years ago by Vickie Lynch

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:20 Changed 8 years ago by Vickie Lynch

  • Status changed from reopened to accepted

comment:21 Changed 8 years ago by Vickie Lynch

Refs #5613 Russell wants inelastic dialog for ISIS instruments

Changeset: 00cd3bdafc500036430a95141bd2f3917e6a29a4

comment:22 Changed 8 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Hi Andrei, Please retest small change

comment:23 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester changed from Andrei Savici to Owen Arnold

comment:24 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

This all still works

comment:25 Changed 8 years ago by Vickie Lynch

Refs #5613 deleted line 777

Changeset: f267bb6c4ad24c5dc4e4f8e83718ad9b11bdb681

comment:26 Changed 8 years ago by Vickie Lynch

Refs #5613 fixed for CNCS non-TOF

Changeset: 3ff0eac2d38f3aba314879d0f145c34ff2ca7e94

comment:27 Changed 8 years ago by Vickie Lynch

Refs #5613 fixed elastic and indirect for non-TOF

Changeset: aa61b61fcef0a8b40376e8ca0359959159feff01

comment:28 Changed 8 years ago by Vickie Lynch

Refs #5613 Russell wants inelastic dialog for ISIS instruments

Changeset: 00cd3bdafc500036430a95141bd2f3917e6a29a4

comment:29 Changed 8 years ago by Vickie Lynch

Refs #5613 deleted line 777

Changeset: f267bb6c4ad24c5dc4e4f8e83718ad9b11bdb681

comment:30 Changed 8 years ago by Vickie Lynch

Refs #5613 fixed for CNCS non-TOF

Changeset: 3ff0eac2d38f3aba314879d0f145c34ff2ca7e94

comment:31 Changed 8 years ago by Vickie Lynch

Refs #5613 fixed elastic and indirect for non-TOF

Changeset: aa61b61fcef0a8b40376e8ca0359959159feff01

comment:32 Changed 8 years ago by Vickie Lynch

Refs #5613 Russell wants inelastic dialog for ISIS instruments

Changeset: 00cd3bdafc500036430a95141bd2f3917e6a29a4

comment:33 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6459

Note: See TracTickets for help on using tickets.