Get rid of LoadRaw1, LoadRaw2 & LoadISISNexus1

[Martyn Gigg]

As far as I know, and I'm fairly confident, these algorithms are not used by anyone. They're very out of date & are causing a maintenance headache so I think they should be deleted.

[Nick Draper]

Moved at the end of release 2.2

[Nick Draper]

Moved to milestone 2.4

[Karl Palmen]

LoadRaw1 and LoadISISNexus1 are not found in DataHandling and no reference to them found in any code. LoadRaw2 is found.

[Karl Palmen]

The following, besides LoadRaw2 itself and its unit test use (or refer to) LoadRaw2.

UnwrapTest

ManagedRawFileWorkspace2DTest

XMLlogfileTest

Also LoadRawHelper has a function, which according to comments is needed only for LoadRaw2.

[Karl Palmen]

None of these three algorithms are found in the wiki.

[Karl Palmen]

LoadRaw2 does not appear to be available in the Mantidplot algorithm menu even within its category of DataHandling\Raw. May this is because only the most recent version is shown (LoadRaw3) of an algorithm of any given name (LoadRaw).

[Karl Palmen]

Unwrap whose unit test uses LoadRaw2 has been marked as deprecated.

[Karl Palmen]

Modified two unit tests to use LoadRaw3 instead of LoadRaw2 re #5627

UnwrapTest.h and ManagedRawFileWorkspace2DTest.h were modified and worked. XMLlogfileTest.h could not so modified, because running it would then cause Mantid to crash.

Changeset: 9953d1481bb5c70c9a8e5d346afa00b6c2e6f7ab

[Karl Palmen]

Both the tests of XMLlogfileTest have the comment

  // LoadRaw2 uses XMLlogfile to populate its parameter map. Hence the test here simply
  // checks that this is done ok

If LoadRaw3 were to also use XMLlogfile for this purpose separate test would or should exist for this. Hence XMLlogfileTest can be removed when LoadRaw2 is removed.

[Karl Palmen]

I've run Mantid having removed LoadRaw2. I see in the Algorithms menu in DataHanding\Raw\LoadRaw v3 that a LoadRaw v1 exists but not LoadRaw v2. I think this is because LoadRaw.h returns a version number of 1. Is this correct?

Therefore the existence of LoadRaw v1 in the Algorithms menu can't be used to fail this ticket when testing.

A similar issues applies to LoadISISNexus causing LoadISISNexus v1 to appear in the Algorithms menu in DataHandling\Nexus\LoadISISNexus v2 .

[Karl Palmen]

Removed LoadRaw2 and its unit test and XMLlogfileTest re #5627

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 8af0947a4349753bc42d92a11e85fdb5a6e43859

[Karl Palmen]

Revert "Removed LoadRaw2 and its unit test and XMLlogfileTest re #5627"

This reverts commit 8af0947a4349753bc42d92a11e85fdb5a6e43859.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f318cdd6fc1bbf46b2b6eb44348af9d1b6fc4612

[Karl Palmen]

The revert was due to failure of VanillaPython. Also Peter Peterson pointed out there was other code that explicitly uses LoadRaw version 2 (either out of reach of my Microsoft Visual Studio or not using the string 'LoadRaw2').

Also it seems that LoadRaw might be LoadRaw1 rather than a generic LoadRaw, likewise with LoadISISNexus.

[Karl Palmen]

I'll cease work on this ticket till I get further help.

[Karl Palmen]

Ideally the unit tests should not call a specific version of LoadRaw (or LoadISISNexus), but obtain the most recent version. This can be done by

IAlgorithm_sptr loader = AlgorithmFactory::Instance().create("LoadRaw");

for LoadRaw.

[Karl Palmen]

My first attempt of using

IAlgorithm_sptr loader = AlgorithmFactory::Instance().create("LoadRaw");

in UnwrapTest lead to a crash. I may try again when I return from leave.

[Karl Palmen]

Modified two unit tests to use LoadRaw3 instead of LoadRaw2 re #5627

UnwrapTest.h and ManagedRawFileWorkspace2DTest.h were modified and worked. XMLlogfileTest.h could not so modified, because running it would then cause Mantid to crash.

Changeset: 9953d1481bb5c70c9a8e5d346afa00b6c2e6f7ab

[Karl Palmen]

Removed LoadRaw2 and its unit test and XMLlogfileTest re #5627

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 8af0947a4349753bc42d92a11e85fdb5a6e43859

[Karl Palmen]

Revert "Removed LoadRaw2 and its unit test and XMLlogfileTest re #5627"

This reverts commit 8af0947a4349753bc42d92a11e85fdb5a6e43859.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f318cdd6fc1bbf46b2b6eb44348af9d1b6fc4612

[Russell Taylor]

Any chance this can be picked up again soon? I'm finding myself once more in the situation of having to (pointlessly) maintain these algorithms on API changes, including spotting one thing that was certainly broken by not picked up by any automated test. I might be able to pick it up myself if there's not enough time over there.

[Karl Palmen]

There's not much chance of me picking it up again, because I'm not in a position to do all the necessary tests. I'd appreciate it if Russell or some one else in a better position. pick this one up.

[Russell Taylor]

Re #5627. Remove LoadISISNexus version 1.

A stub has been left that always fails and informs the user that they should use version 2.

Changeset: cb97660e9fec1afab04b6ec619bb90a670939f4f

[Russell Taylor]

Re #5627. Remove LoadRaw version 1.

A stub has been left that always fails and informs the user that they should use version 3. This will break some unit tests - they will be fixed next.

Changeset: a8526a4afe0957dbecfa34909e022a3c03006a46

[Russell Taylor]

Re #5627. Remove unnecessary inclusions of LoadRaw.h

Changeset: cca08afeff53b61e9873b4b022494c9972b4c087

[Russell Taylor]

Re #5627. Replace unit test that used LoadRaw V1

...with one that doesn't load real data.

Changeset: d5cfeeb3212e51872e6c46b1aa92daf8f0fe462a

[Russell Taylor]

Re #5627. Remove LoadRaw version 2.

A stub has been left that always fails and informs the user that they should use version 3.

Changeset: 3f5eb1014d6fe8e6fec1f8111fbba7cc142010e5

[Russell Taylor]

Tester: It all happened with the commits from comment:29 onwards. Branch is feature/5627_remove_loadraw_V1andV2.

Testing is easy - look at the meagre remnants of the 3 removed algorithms and make sure that no automated tests are failing because they're gone. Try running them both from the algorithm list in MantidPlot (the tree, you can't access old versions by typing the names) and from python. The algorithm will fail and you will see a message explaining that it's been removed.

[Russell Taylor]

Re #5627. Remove LoadISISNexus version 1.

A stub has been left that always fails and informs the user that they should use version 2.

Changeset: cb97660e9fec1afab04b6ec619bb90a670939f4f

[Russell Taylor]

Re #5627. Remove LoadRaw version 1.

A stub has been left that always fails and informs the user that they should use version 3. This will break some unit tests - they will be fixed next.

Changeset: a8526a4afe0957dbecfa34909e022a3c03006a46

[Russell Taylor]

Re #5627. Remove unnecessary inclusions of LoadRaw.h

Changeset: cca08afeff53b61e9873b4b022494c9972b4c087

[Russell Taylor]

Re #5627. Replace unit test that used LoadRaw V1

...with one that doesn't load real data.

Changeset: d5cfeeb3212e51872e6c46b1aa92daf8f0fe462a

[Russell Taylor]

Re #5627. Remove LoadRaw version 2.

A stub has been left that always fails and informs the user that they should use version 3.

Changeset: 3f5eb1014d6fe8e6fec1f8111fbba7cc142010e5

[Russell Taylor]

Re #5627. A few places that include LoadRaw.h unnecessarily.

Changeset: 543ec40a282396bd732fc4a4bf70de0bcd3dc6b4

[Russell Taylor]

Re #5627. A few places that include LoadRaw.h unnecessarily.

Changeset: 543ec40a282396bd732fc4a4bf70de0bcd3dc6b4

[Russell Taylor]

Re #5627. Remove LoadISISNexus version 1.

A stub has been left that always fails and informs the user that they should use version 2.

Changeset: cb97660e9fec1afab04b6ec619bb90a670939f4f

[Russell Taylor]

Re #5627. Remove LoadRaw version 1.

A stub has been left that always fails and informs the user that they should use version 3. This will break some unit tests - they will be fixed next.

Changeset: a8526a4afe0957dbecfa34909e022a3c03006a46

[Russell Taylor]

Re #5627. Remove unnecessary inclusions of LoadRaw.h

Changeset: cca08afeff53b61e9873b4b022494c9972b4c087

[Russell Taylor]

Re #5627. Replace unit test that used LoadRaw V1

...with one that doesn't load real data.

Changeset: d5cfeeb3212e51872e6c46b1aa92daf8f0fe462a

[Russell Taylor]

Re #5627. Remove LoadRaw version 2.

A stub has been left that always fails and informs the user that they should use version 3.

Changeset: 3f5eb1014d6fe8e6fec1f8111fbba7cc142010e5

[Russell Taylor]

Re #5627. A few places that include LoadRaw.h unnecessarily.

Changeset: 543ec40a282396bd732fc4a4bf70de0bcd3dc6b4

[Russell Taylor]

Re #5627. Remove LoadISISNexus version 1.

A stub has been left that always fails and informs the user that they should use version 2.

Changeset: cb97660e9fec1afab04b6ec619bb90a670939f4f

[Russell Taylor]

Re #5627. Remove LoadRaw version 1.

A stub has been left that always fails and informs the user that they should use version 3. This will break some unit tests - they will be fixed next.

Changeset: a8526a4afe0957dbecfa34909e022a3c03006a46

[Russell Taylor]

Re #5627. Remove unnecessary inclusions of LoadRaw.h

Changeset: cca08afeff53b61e9873b4b022494c9972b4c087

[Russell Taylor]

Re #5627. Replace unit test that used LoadRaw V1

...with one that doesn't load real data.

Changeset: d5cfeeb3212e51872e6c46b1aa92daf8f0fe462a

[Russell Taylor]

Re #5627. Remove LoadRaw version 2.

A stub has been left that always fails and informs the user that they should use version 3.

Changeset: 3f5eb1014d6fe8e6fec1f8111fbba7cc142010e5

[Russell Taylor]

Re #5627. A few places that include LoadRaw.h unnecessarily.

Changeset: 543ec40a282396bd732fc4a4bf70de0bcd3dc6b4

[Russell Taylor]

Re #5627. Remove LoadISISNexus version 1.

A stub has been left that always fails and informs the user that they should use version 2.

Changeset: cb97660e9fec1afab04b6ec619bb90a670939f4f

[Russell Taylor]

Re #5627. Remove LoadRaw version 1.

A stub has been left that always fails and informs the user that they should use version 3. This will break some unit tests - they will be fixed next.

Changeset: a8526a4afe0957dbecfa34909e022a3c03006a46

[Russell Taylor]

Re #5627. Remove unnecessary inclusions of LoadRaw.h

Changeset: cca08afeff53b61e9873b4b022494c9972b4c087

[Russell Taylor]

Re #5627. Replace unit test that used LoadRaw V1

...with one that doesn't load real data.

Changeset: d5cfeeb3212e51872e6c46b1aa92daf8f0fe462a

[Russell Taylor]

Re #5627. Remove LoadRaw version 2.

A stub has been left that always fails and informs the user that they should use version 3.

Changeset: 3f5eb1014d6fe8e6fec1f8111fbba7cc142010e5

[Russell Taylor]

Re #5627. A few places that include LoadRaw.h unnecessarily.

Changeset: 543ec40a282396bd732fc4a4bf70de0bcd3dc6b4

[Russell Taylor]

Re #5627. Remove LoadISISNexus version 1.

A stub has been left that always fails and informs the user that they should use version 2.

Changeset: cb97660e9fec1afab04b6ec619bb90a670939f4f

[Russell Taylor]

Re #5627. Remove LoadRaw version 1.

A stub has been left that always fails and informs the user that they should use version 3. This will break some unit tests - they will be fixed next.

Changeset: a8526a4afe0957dbecfa34909e022a3c03006a46

[Russell Taylor]

Re #5627. Remove unnecessary inclusions of LoadRaw.h

Changeset: cca08afeff53b61e9873b4b022494c9972b4c087

[Russell Taylor]

Re #5627. Replace unit test that used LoadRaw V1

...with one that doesn't load real data.

Changeset: d5cfeeb3212e51872e6c46b1aa92daf8f0fe462a

[Russell Taylor]

Re #5627. Remove LoadRaw version 2.

A stub has been left that always fails and informs the user that they should use version 3.

Changeset: 3f5eb1014d6fe8e6fec1f8111fbba7cc142010e5

[Russell Taylor]

Re #5627. A few places that include LoadRaw.h unnecessarily.

Changeset: 543ec40a282396bd732fc4a4bf70de0bcd3dc6b4

[Russell Taylor]

Re #5627. Remove LoadISISNexus version 1.

A stub has been left that always fails and informs the user that they should use version 2.

Changeset: cb97660e9fec1afab04b6ec619bb90a670939f4f

[Russell Taylor]

Re #5627. Remove LoadRaw version 1.

A stub has been left that always fails and informs the user that they should use version 3. This will break some unit tests - they will be fixed next.

Changeset: a8526a4afe0957dbecfa34909e022a3c03006a46

[Russell Taylor]

Re #5627. Remove unnecessary inclusions of LoadRaw.h

Changeset: cca08afeff53b61e9873b4b022494c9972b4c087

[Russell Taylor]

Re #5627. Replace unit test that used LoadRaw V1

...with one that doesn't load real data.

Changeset: d5cfeeb3212e51872e6c46b1aa92daf8f0fe462a

[Russell Taylor]

Re #5627. Remove LoadRaw version 2.

A stub has been left that always fails and informs the user that they should use version 3.

Changeset: 3f5eb1014d6fe8e6fec1f8111fbba7cc142010e5

[Russell Taylor]

Re #5627. A few places that include LoadRaw.h unnecessarily.

Changeset: 543ec40a282396bd732fc4a4bf70de0bcd3dc6b4

[Stuart Campbell]

This ticket has been transferred to github issue ​6473