MergeRuns with Multiperiod Data

[Owen Arnold]

This defect has been reported by Tim Charlton.

I have generated a test-case below to assert the working behaviour, which shows where/why it is failing, and should also provide a useful test case to verify a future fix.

a = Load(Filename='POLREF00004699.nxs')
b = CloneWorkspace(InputWorkspace=a)
c = MergeRuns(InputWorkspaces='a,b')

# Output workspace should be a group workspace too.
if not isinstance(c, type(b)):
        raise RuntimeError("In and out ws groups are unequal in size")

# If the output is a group workspace, check its size
if not c.size() == a.size():
        raise RuntimeError("MergeRuns is not working for multiperiod data")

# Should sum across periods.
for i in range(0, a.size()):
        expectedValue = a[i].readY(0)[0] + b[i].readY(0)[0]
        actualValue = c[i].readY(0)[0]
        print expectedValue, actualValue
        if not actualValue == expectedValue:
                raise RuntimeError("Should be summing on a period by period basis within the group")

[Owen Arnold]

refs #5646. Now passes failing test case.

Changeset: 075debe785f596cb9e96c962af4afa23e5910dec

[Owen Arnold]

refs #5646. Detailed validation and testing of new functionality.

Changeset: 500c7cd1ac570b77f931aa5bc65e5aae2e56afe4

[Owen Arnold]

refs #5646. Update wiki documentation.

Changeset: 180742dd0fd34f84de85069af786b2c893168696

[Owen Arnold]

refs #5646. Fix test, warning and notifications.

Changeset: 0816ec239745d5e5ada037cb4d07d2c6e6d1dc4f

[Owen Arnold]

refs #5646. Fix GCC error.

Changeset: f41295db1c489f5ba70d0e3ddb26f92696281689

[Owen Arnold]

Tester: The previously failing test case provided in the ticket description should now work. There are also a large number of new unit tests covering this new feature as well as the original/default behaviour.

[Owen Arnold]

refs #5646. Now passes failing test case.

Changeset: 075debe785f596cb9e96c962af4afa23e5910dec

[Owen Arnold]

refs #5646. Detailed validation and testing of new functionality.

Changeset: 500c7cd1ac570b77f931aa5bc65e5aae2e56afe4

[Owen Arnold]

refs #5646. Update wiki documentation.

Changeset: 180742dd0fd34f84de85069af786b2c893168696

[Owen Arnold]

refs #5646. Fix test, warning and notifications.

Changeset: 0816ec239745d5e5ada037cb4d07d2c6e6d1dc4f

[Owen Arnold]

refs #5646. Fix GCC error.

Changeset: f41295db1c489f5ba70d0e3ddb26f92696281689

[Owen Arnold]

refs #5646. Ensure that progress set to finish

Changeset: a56b196019dc1ddd75bc5f26226ae1711084ca5c

[Dereck Kachere]

Ran the test case and it worked fine. Different workspaces too.

I then deliberately input workspaces which one could not run a size method on, so the test case failed just as it should have.

[Owen Arnold]

refs #5646. Ensure that progress set to finish

Changeset: a56b196019dc1ddd75bc5f26226ae1711084ca5c

[Owen Arnold]

refs #5646. Ensure that progress set to finish

Changeset: a56b196019dc1ddd75bc5f26226ae1711084ca5c

[Stuart Campbell]

This ticket has been transferred to github issue ​6492