Ticket #5655 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create workflow algorithm for DGS detector vanadium processing

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

A workflow algorithm should be created that handles the processing of detector vanadium data for DGS reduction.

Change History

comment:1 Changed 8 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Michael Reuter

Refs #5655. Starting algorithm.

Changeset: 2e659564bd19b2fe1934a958c51682be0b8b624a

comment:3 Changed 8 years ago by Michael Reuter

Refs #5655. Rounding out most of the calculations.

Changeset: 6d9772b5c4574d7f3500e496db5b144a939986f0

comment:4 Changed 8 years ago by Michael Reuter

Refs #5655. Changing to using property manager.

Changeset: e9d3851031fcac6ad969f2aad40183d16ca5826e

comment:5 Changed 8 years ago by Michael Reuter

Refs #5453, #5454 and #5655. New detvan int unit.

Changeset: 900c326b36a7d20abd01cea8961b0c1316237daa

comment:6 Changed 8 years ago by Michael Reuter

Refs #5453 and #5655. Fixes for det van processing.

Changeset: a4bc9baa3848f3c514a952e1d016a2f1a65dac01

comment:7 Changed 8 years ago by Michael Reuter

Refs #5453 and #5655. Hard masking.

Adding the loading of a hard mask and applying it to the detector vanadium data.

Changeset: 475ab98c01c6f18fe6737a10cab9694c2d96fee8

comment:8 Changed 8 years ago by Michael Reuter

Refs #5453, #5623, #5655 and #5678. Major changes.

I had to a lot of major changes to stop workspaces from getting stomped on. I had to turn off reliance on the ADS and pass workspace pointers around by hand to keep things separated.

Changeset: 346d66e4d08660082560658249d72915946d71ea

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:10 Changed 8 years ago by Michael Reuter

Refs #5655. Changing to using property manager.

Changeset: e9d3851031fcac6ad969f2aad40183d16ca5826e

comment:11 Changed 8 years ago by Michael Reuter

Refs #5453, #5454 and #5655. New detvan int unit.

Changeset: 900c326b36a7d20abd01cea8961b0c1316237daa

comment:12 Changed 8 years ago by Michael Reuter

Refs #5453 and #5655. Fixes for det van processing.

Changeset: a4bc9baa3848f3c514a952e1d016a2f1a65dac01

comment:13 Changed 8 years ago by Michael Reuter

Refs #5453 and #5655. Hard masking.

Adding the loading of a hard mask and applying it to the detector vanadium data.

Changeset: 475ab98c01c6f18fe6737a10cab9694c2d96fee8

comment:14 Changed 8 years ago by Michael Reuter

Refs #5453, #5623, #5655 and #5678. Major changes.

I had to a lot of major changes to stop workspaces from getting stomped on. I had to turn off reliance on the ADS and pass workspace pointers around by hand to keep things separated.

Changeset: 346d66e4d08660082560658249d72915946d71ea

comment:15 Changed 8 years ago by Michael Reuter

Refs #5453 and #5655. Applying diagnostic mask to detvan.

Changeset: 1841fa68fbe6e2be49ef41cf2cff66846c4757ca

comment:16 Changed 8 years ago by Michael Reuter

Refs #5453, #5623 and #5655. Trying to save proc detvan.

Changeset: cfd366cd0c7d007a65c687322fba987e51d85e83

comment:17 Changed 8 years ago by Michael Reuter

Refs #5655. Adding grouping capability.

Changeset: e37850db8be54f9f8a9355d89a091360bc778191

comment:18 Changed 8 years ago by Michael Reuter

Refs #5655. Updating formatting.

Changeset: 8671337670b15bb6207ec43571a6f0cc8998ca16

comment:19 Changed 8 years ago by Michael Reuter

Refs #5453 and #5655. Handling masking/grouping via workspaces.

Changeset: 2bb97f36370ffb1060f77157fad593440e67bcf1

comment:20 Changed 8 years ago by Michael Reuter

Refs #5655. Fixing file saving.

Changeset: 17c8ea84ebd247cd5bf67358dc08f88af80a5169

comment:21 Changed 8 years ago by Michael Reuter

Refs #5655. Fixing workspace saving with masking.

Changeset: 9ef290f05b106f0a3d9082905ac15d12675f1ebe

comment:22 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655, #5678 and #5855. Workspace prop changes.

Lots of changes relating to output workspace space properties. Handling them in a consistent manner across all algorithms.

Changeset: 3cd13c6414d1262092dc84a299c447076e0155ed

comment:23 Changed 8 years ago by Michael Reuter

Refs #5605 and #5655. Add property for abs units grouping.

Changeset: 82f34d611e3d91cbf6d4af6f8099b10fbc7309a2

comment:24 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655 and #5678. Removing enable history calls.

Changeset: 462c15295188e4fb197e7547417d7a8a86ea1a5f

comment:25 Changed 8 years ago by Michael Reuter

Refs #5655. Fixing file saving.

Changeset: 695a1e04ebd8cd15e6219cdee412d537bd008134

comment:26 Changed 8 years ago by Michael Reuter

Refs #5655 and #5678. Changes to help big memory detvan.

Changeset: 62c492f0a2faea2c9097696ba1628f81db76f440

comment:27 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5655 amd #5678. More changes.

  • Switched to dividing by detector vanadium before grouping.
  • Eliminated grouping in processing the detector vanadium.
  • Adding some more intermediate workspaces.
  • Fixing internal workspace names for file saving.
  • Removing more things from the ADS. Changeset: 7887a021af527cedcbe06d03d1e0a7275a122427

comment:28 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5623, #5655 and #5678. More changes.

comment:29 Changed 8 years ago by Michael Reuter

Refs #5623, #5655 and #5678. Using new helper function.

Changeset: 0375945966842fffed2c14440165eb2f62b32516

comment:30 Changed 8 years ago by Michael Reuter

Refs #5655. Adding filename property capability.

Changeset: 684f5fe3061a57f22f1ed96ccae203c3e92cb7f5

comment:31 Changed 8 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

If you test #5453 or #5454 and use a detector vanadium file, this comes along for the ride.

comment:32 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:33 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

Tested as part of DGSReduction

comment:34 Changed 8 years ago by Michael Reuter

Refs #5453 and #5655. Applying diagnostic mask to detvan.

Changeset: 1841fa68fbe6e2be49ef41cf2cff66846c4757ca

comment:35 Changed 8 years ago by Michael Reuter

Refs #5453, #5623 and #5655. Trying to save proc detvan.

Changeset: cfd366cd0c7d007a65c687322fba987e51d85e83

comment:36 Changed 8 years ago by Michael Reuter

Refs #5655. Adding grouping capability.

Changeset: e37850db8be54f9f8a9355d89a091360bc778191

comment:37 Changed 8 years ago by Michael Reuter

Refs #5655. Updating formatting.

Changeset: 8671337670b15bb6207ec43571a6f0cc8998ca16

comment:38 Changed 8 years ago by Michael Reuter

Refs #5453 and #5655. Handling masking/grouping via workspaces.

Changeset: 2bb97f36370ffb1060f77157fad593440e67bcf1

comment:39 Changed 8 years ago by Michael Reuter

Refs #5655. Fixing file saving.

Changeset: 17c8ea84ebd247cd5bf67358dc08f88af80a5169

comment:40 Changed 8 years ago by Michael Reuter

Refs #5655. Fixing workspace saving with masking.

Changeset: 9ef290f05b106f0a3d9082905ac15d12675f1ebe

comment:41 Changed 8 years ago by Michael Reuter

Refs #5655. Handle old format grouping file and allow no grouping.

Changeset: ca09b12b9a341e8a60d5390dccac54305ca84254

comment:42 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655, #5678 and #5855. Workspace prop changes.

Lots of changes relating to output workspace space properties. Handling them in a consistent manner across all algorithms.

Changeset: 3cd13c6414d1262092dc84a299c447076e0155ed

comment:43 Changed 8 years ago by Michael Reuter

Refs #5605 and #5655. Add property for abs units grouping.

Changeset: 82f34d611e3d91cbf6d4af6f8099b10fbc7309a2

comment:44 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655 and #5678. Removing enable history calls.

Changeset: 462c15295188e4fb197e7547417d7a8a86ea1a5f

comment:45 Changed 8 years ago by Michael Reuter

Refs #5655. Fixing file saving.

Changeset: 695a1e04ebd8cd15e6219cdee412d537bd008134

comment:46 Changed 8 years ago by Michael Reuter

Refs #5655 and #5678. Changes to help big memory detvan.

Changeset: 62c492f0a2faea2c9097696ba1628f81db76f440

comment:47 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5655 amd #5678. More changes.

  • Switched to dividing by detector vanadium before grouping.
  • Eliminated grouping in processing the detector vanadium.
  • Adding some more intermediate workspaces.
  • Fixing internal workspace names for file saving.
  • Removing more things from the ADS. Changeset: 7887a021af527cedcbe06d03d1e0a7275a122427

comment:48 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5623, #5655 and #5678. More changes.

comment:49 Changed 8 years ago by Michael Reuter

Refs #5623, #5655 and #5678. Using new helper function.

Changeset: 0375945966842fffed2c14440165eb2f62b32516

comment:50 Changed 8 years ago by Michael Reuter

Refs #5655. Adding filename property capability.

Changeset: 684f5fe3061a57f22f1ed96ccae203c3e92cb7f5

comment:51 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6501

Note: See TracTickets for help on using tickets.