Ticket #5666 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Muon: Apply period substraction after analysis method

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: critical Milestone: Release 2.3
Component: MantidPlot Keywords:
Cc: Blocked By: #6002
Blocking: Tester: Nick Draper

Description

At the moment when plotting e.g. a pair on period data where e.g. period 2 is substracted by period 1 the steps are:

  1. substract 2-1
  2. apply asymmetry algorithm

As just discussed with Steve this has a side effect for this particular cause. A proposed way around this is to swap the order of 1. and 2. above.

Attachments

Untitled.png​ (13.4 KB) - added by Nick Draper 8 years ago.

Change History

comment:1 Changed 8 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Peter Parker
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Anders Markvardsen

  • Owner changed from Peter Parker to Anders Markvardsen

comment:3 Changed 8 years ago by Anders Markvardsen

reorganised muon code to handle period at the end. re #5666

Changeset: 636f9cfe1c5fb8fab1d58889810ec6e7afecdf64

comment:4 Changed 8 years ago by Anders Markvardsen

  • Blocked By 6002 added

comment:5 Changed 8 years ago by Anders Markvardsen

fsdafasklasfdsaferakoaisdfjkl. re #5666

Changeset: 13600f9e15de789079cf34bde10aa52e7cb43b6b

comment:6 Changed 8 years ago by Anders Markvardsen

  • Status changed from assigned to accepted

Note Steve Cottrell will test this ticket. So wait with testing this one untill his feedback

comment:7 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Anders Markvardsen

  • Status changed from verify to reopened
  • Resolution fixed deleted

Steve done some testing (already!). He writes:

looking at some HiFi data and then at the EMU period data file things seem to be working fine, including period addition/subtraction.

One very minor problem appeared when I accidently asked for 'Period 1 - Period 1', which gave an 'unexpected exception' error

comment:9 Changed 8 years ago by Anders Markvardsen

MUON: prevent user from selection 'Period 1 - Period 1'. re #5666

Changeset: a9aaed54a9411d65ded47891b233d00cee7720a4

comment:10 Changed 8 years ago by Anders Markvardsen

  • Status changed from reopened to accepted

comment:11 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 8 years ago by Anders Markvardsen

Note this ticket is actually really easy to test now!

Since Steve Cottrell done 99% of the testing for this ticket.

The only thing left is

  1. open MuonAnalysis interface
  1. hit the browse button and open a data file with periods e.g. any of the Muon datasets in AutoTestData directory
  1. The right most combo-box to the right of the label: "Data collected in ...." with

now display "None"

  1. Try to change "None" to the same period as 1 - this should now not be possible

comment:13 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:14 Changed 8 years ago by Nick Draper

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Failure when changing none to same period as one

Tested with a fresh debug build from the release branch at 11am 30/10/2012.

Failure picture attached.

Changed 8 years ago by Nick Draper

comment:15 Changed 8 years ago by Anders Markvardsen

Prevent user from selected period 1 - period 1. re #5666

when either of the two period boxes are changed

Changeset: cdd185bc2f55f8ab9b14a2b14d59887423ce8ad4

comment:16 Changed 8 years ago by Anders Markvardsen

  • Status changed from reopened to accepted

see comment 12 for how to test

comment:17 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:18 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying

comment:19 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

comment:20 Changed 8 years ago by Anders Markvardsen

reorganised muon code to handle period at the end. re #5666

Changeset: 636f9cfe1c5fb8fab1d58889810ec6e7afecdf64

comment:21 Changed 8 years ago by Anders Markvardsen

fsdafasklasfdsaferakoaisdfjkl. re #5666

Changeset: 13600f9e15de789079cf34bde10aa52e7cb43b6b

comment:22 Changed 8 years ago by Anders Markvardsen

MUON: prevent user from selection 'Period 1 - Period 1'. re #5666

Changeset: a9aaed54a9411d65ded47891b233d00cee7720a4

comment:23 Changed 8 years ago by Anders Markvardsen

Prevent user from selected period 1 - period 1. re #5666

when either of the two period boxes are changed

Changeset: cdd185bc2f55f8ab9b14a2b14d59887423ce8ad4

comment:24 Changed 8 years ago by Anders Markvardsen

MUON: prevent user from selection 'Period 1 - Period 1'. re #5666

Changeset: a9aaed54a9411d65ded47891b233d00cee7720a4

comment:25 Changed 8 years ago by Anders Markvardsen

Prevent user from selected period 1 - period 1. re #5666

when either of the two period boxes are changed

Changeset: cdd185bc2f55f8ab9b14a2b14d59887423ce8ad4

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6512

Note: See TracTickets for help on using tickets.