Ticket #5674 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Make DetectorDiagnostic look like diagnostics.diagnose

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The current DetectorDiagnostic algorithm should be aligned to recreate the calls performed in the scripts/Inelastic/diagnostics.py diagnose routine. The realignment will require certain workspaces to be passed to the algorithm.

Change History

comment:1 Changed 8 years ago by Michael Reuter

  • Status changed from new to assigned

comment:2 Changed 8 years ago by Michael Reuter

  • Status changed from assigned to accepted

comment:3 Changed 8 years ago by Michael Reuter

Refs #5674. First cut at realignment.

Changeset: 0d3348e43626c461476155acd7a1e7b067cd70ef

comment:4 Changed 8 years ago by Michael Reuter

Refs #5674. Fix parameter group.

Changeset: c1152bf4b1ac59a4b0af48e27ad49254ec93af0e

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:6 Changed 8 years ago by Michael Reuter

Refs #5674. First cut at realignment.

Changeset: 0d3348e43626c461476155acd7a1e7b067cd70ef

comment:7 Changed 8 years ago by Michael Reuter

Refs #5674. Fix parameter group.

Changeset: c1152bf4b1ac59a4b0af48e27ad49254ec93af0e

comment:8 Changed 8 years ago by Michael Reuter

Refs #5674. Parameter name and functional renorm.

Changeset: 41d15064ff75522887cab277df1e7f5259174d32

comment:9 Changed 8 years ago by Michael Reuter

Refs #5674. Missed changing a name.

Changeset: f8784c4d119ce2dc4b41745c72cd1f6b854b66e6

comment:10 Changed 8 years ago by Michael Reuter

Refs #5674. Lots of changes to get things working.

  • Changed to getting workspace pointers from properties
  • Used MaskDetectors to gather up all information as BinaryOperateMask was unreliable.
  • Using ExtractMask to get final mask and report numbers due to flaw in MedianDetectorTest reporting.
  • Removed integration steps as detector vanadium workspaces should already be processed.
  • Added wiki documentation. Changeset: 85aaf0c24b62462b18f904a368ecabe40f1160cf

comment:11 Changed 8 years ago by Michael Reuter

Refs #5674. Adding system test for DgsDiagnose/DetectorDiagnostic.

Changeset: 3581137f03316fc4d4ce3e26a1035b1c6929e0e3

comment:12 Changed 8 years ago by Michael Reuter

Refs #5674. Adding hard mask application.

Changeset: d7473a168485985eee9f6228009830164ba7c03b

comment:13 Changed 8 years ago by Michael Reuter

Refs #5674. Formatting fixes and this pointers.

Changeset: 9b7c97dc5cd0f8512dd6e0a475c645e3afb25e1c

comment:14 Changed 8 years ago by Michael Reuter

Refs #5674. Workspace name updates.

Changeset: 5c559b8c8969e588d9c9d5cc6ac1264fc863bd42

comment:15 Changed 8 years ago by Michael Reuter

Refs #5674. Parameter name and functional renorm.

Changeset: 41d15064ff75522887cab277df1e7f5259174d32

comment:16 Changed 8 years ago by Michael Reuter

Refs #5674. Missed changing a name.

Changeset: f8784c4d119ce2dc4b41745c72cd1f6b854b66e6

comment:17 Changed 8 years ago by Michael Reuter

Refs #5674. Lots of changes to get things working.

  • Changed to getting workspace pointers from properties
  • Used MaskDetectors to gather up all information as BinaryOperateMask was unreliable.
  • Using ExtractMask to get final mask and report numbers due to flaw in MedianDetectorTest reporting.
  • Removed integration steps as detector vanadium workspaces should already be processed.
  • Added wiki documentation. Changeset: 85aaf0c24b62462b18f904a368ecabe40f1160cf

comment:18 Changed 8 years ago by Michael Reuter

Refs #5674. Make only sample WS trigger for bleed test.

Changeset: 9f15c4c1959bb4ab0ae79507f753d19115c20997

comment:19 Changed 8 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

This can be tested as part of #5678.

comment:20 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:21 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

Tested as part of DGSReduction

comment:22 Changed 8 years ago by Michael Reuter

Refs #5674. Adding hard mask application.

Changeset: d7473a168485985eee9f6228009830164ba7c03b

comment:23 Changed 8 years ago by Michael Reuter

Refs #5674. Formatting fixes and this pointers.

Changeset: 9b7c97dc5cd0f8512dd6e0a475c645e3afb25e1c

comment:24 Changed 8 years ago by Michael Reuter

Refs #5674. Workspace name updates.

Changeset: 5c559b8c8969e588d9c9d5cc6ac1264fc863bd42

comment:25 Changed 8 years ago by Michael Reuter

Refs #5674. Make only sample WS trigger for bleed test.

Changeset: 9f15c4c1959bb4ab0ae79507f753d19115c20997

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6520

Note: See TracTickets for help on using tickets.