Ticket #5682 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Reinstate Old ConvertToMDEvents code untill the apoling performance of ConvertToMD code fixedof

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 2.2
Component: VATES Keywords:
Cc: saviciat@… Blocked By:
Blocking: Tester: Martyn Gigg

Description


Change History

comment:1 Changed 8 years ago by Alex Buts

  • Cc saviciat@… added
  • Status changed from new to accepted

The code is nice and "Simple" but while tried single-threaded on ConvertToDifractionWorkpspace runs 10 times slower then Janik's specialized code (multithreaded) and 20 times slower then old ConvertToMDEvents code.

Until this problem is fixed, it should not be used.

comment:2 Changed 8 years ago by Alex Buts

refs #5682 Old ConvertToMD merged with current branch.

some inconsistencies still possible

Changeset: ee6462d50586869c267e5a5d7d2d1fc0ceb23403

comment:3 Changed 8 years ago by Alex Buts

refs #5682 everything mainly in place but no tests yet.

and there are bugs too.

Changeset: 48ba4811038ccd429fe4dcfae24420584607405b

comment:4 Changed 8 years ago by Alex Buts

refs #5682 Changes which hide the modifications, introduced earlier

according to ticket #5552

Changeset: 40b7b2cc6956d45a54d2aa1f4ac04c9811c9871b

comment:5 Changed 8 years ago by Alex Buts

refs #5682 fixing Unix warnings

Changeset: c25211cee2c3f1126108c3c47925e6203deb0b70

comment:6 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

The code returned to MANTID for further investigation. All old code files have text string /TODO: FOR DEPRICATION */ in them which will make later deprecation task very simple.

Almost no tests were returned as code will be probably deprecated.

comment:7 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:8 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified ConvertToMDEvents does not call ConvertToMD and still works.

comment:9 Changed 8 years ago by Martyn Gigg

See #5710 for further comments.

comment:10 Changed 8 years ago by Alex Buts

refs #5682 Old ConvertToMD merged with current branch.

some inconsistencies still possible

Changeset: ee6462d50586869c267e5a5d7d2d1fc0ceb23403

comment:11 Changed 8 years ago by Alex Buts

refs #5682 everything mainly in place but no tests yet.

and there are bugs too.

Changeset: 48ba4811038ccd429fe4dcfae24420584607405b

comment:12 Changed 8 years ago by Alex Buts

refs #5682 Changes which hide the modifications, introduced earlier

according to ticket #5552

Changeset: 40b7b2cc6956d45a54d2aa1f4ac04c9811c9871b

comment:13 Changed 8 years ago by Alex Buts

refs #5682 fixing Unix warnings

Changeset: c25211cee2c3f1126108c3c47925e6203deb0b70

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6528

Note: See TracTickets for help on using tickets.