Ticket #5693 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

MantidPlot: ColorMap does not revert to default automatically.

Reported by: Michael Reuter Owned by: Jay Rainey
Priority: critical Milestone: Release 2.6
Component: MantidPlot Keywords: Student,First
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

If one uses the custom colormap to switch and then try to switch back to the default colormap, MantidPlot must be restarted in order for this to take effect. I don't know of many programs that require a restart to change a colormap. I've observed this behavior on both Windoze (install kit) and Linux (dev version).

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:2 Changed 8 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:4 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:5 Changed 7 years ago by Nick Draper

  • Keywords Student added

comment:6 Changed 7 years ago by Martyn Gigg

  • Keywords Student,First added; Student removed

comment:7 Changed 7 years ago by Nick Draper

  • Owner changed from Anyone to Jay Rainey

comment:8 Changed 7 years ago by Jay Rainey

  • Status changed from assigned to accepted

comment:9 Changed 7 years ago by Jay Rainey

refs #5693. Fixed color map switching.

Changeset: 4bf72a5b9be01ad558a2f5a100e9ded31e61afa7

comment:10 Changed 7 years ago by Jay Rainey

refs #5693. Fixed color map switching.

Changeset: 2dd1aaeaf0b952675bda8a9ada6ed4c7097ee6ba

comment:11 Changed 7 years ago by Jay Rainey

refs #5693. Prevented changing of custom color map.

Changeset: e3979f0854e5c26c62ab35712b1651ab905ea80a

comment:12 Changed 7 years ago by Jay Rainey

refs #5693. Prevent change of custom colormap when btn not selected.

Changeset: 7411a56e206f0e9209c73cd8846515c02847cdff

comment:13 Changed 7 years ago by Jay Rainey

refs #5693. Removed some files accidently committed

Changeset: 2ced8240fa29840ef9d86d57a25d4e82ed6e0a5b

comment:14 Changed 7 years ago by Jay Rainey

  • Status changed from accepted to verify
  • Resolution set to fixed

The problem was that when the user switched between the default, custom color map it would not revert to the default, and required a restart to do so. It now should revert between these.

Tester: Load data into workspace, and select "Color Fill Plot". Left click the image, then select UserHelperFunction under Layer1. You should now see gray scale, default, and custom color map.

comment:15 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:16 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

OK, the color map switching seems to work. However, it looks like a bug in the custom colormap dialog was introduced. To see the issue, do the following with the layer properties dialog open:

  1. Click on Custom Color Map and then the Select ColorMap button
  2. Select a colormap in the Pick a Colormap dialog and click Open
  3. Dialog opens again, so I have to select and click again.
  4. Dialog closes, hit Apply, see colormap change.
  5. Click on Default ColorMap, hit Apply and colormap changes.
  6. Click on Custom Color Map and then the Select ColorMap button
  7. Select a colormap in the Pick a Colormap dialog and click Open
  8. Dialog opens again, and I have to click Open 3 more times to get it to select colormap
  9. Dialog finally closes, hit Apply, see colormap change.

If I repeat steps 5-7 and then try to repeat step 8 it requires 6 total clicks on Open to get the Dialog to finally close. Each iteration increases the number of clicks required by 2. I see this behavior on Ubuntu and RHEL6.

comment:17 Changed 7 years ago by Jay Rainey

  • Status changed from reopened to accepted

comment:18 Changed 7 years ago by Jay Rainey

refs #5693. Fixed dialog box bug.

Changeset: cbaa082ea4977aad9381b8b79b3219460a1ea096

comment:19 Changed 7 years ago by Jay Rainey

Refs #5693. Tidied up method.

Changeset: 236734c35147444d04d8453e2cdd5c851df8fa7e

comment:20 Changed 7 years ago by Jay Rainey

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:21 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:22 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

This looks to be working correctly now.

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6539

Note: See TracTickets for help on using tickets.