Ticket #5695 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Can't cancel SimulateResolutionConvolvedModel

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Fit only polls the progress reporter once per iteration. If a function takes a long time to evaluate or is only evaluated once, like in this case, then the algorithm cannot be cancelled.

This is a substantial problem as the algorithm can/will take hours to run.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

Implement progress reporting on ResolutionConvolvedModel. Refs #5695

Progress implies cancellation. The polling is every 0.01% of calls so it should be repsonsive enough. Without this you had to kill Mantid to stop it!

Changeset: 7173de35eaa650919439fae74b0373639280fc00

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

Tested using script from #5397. This is reporting at a good frequency at the moment. Also, actually finished soon after 100% reported.

comment:6 Changed 8 years ago by Martyn Gigg

Implement progress reporting on ResolutionConvolvedModel. Refs #5695

Progress implies cancellation. The polling is every 0.01% of calls so it should be repsonsive enough. Without this you had to kill Mantid to stop it!

Changeset: 7173de35eaa650919439fae74b0373639280fc00

comment:7 Changed 8 years ago by Martyn Gigg

Implement progress reporting on ResolutionConvolvedModel. Refs #5695

Progress implies cancellation. The polling is every 0.01% of calls so it should be repsonsive enough. Without this you had to kill Mantid to stop it!

Changeset: 7173de35eaa650919439fae74b0373639280fc00

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6541

Note: See TracTickets for help on using tickets.