Ticket #5715 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Proper Fix For TextEditor in MantidPlot

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Problem detailed in #5714 will have to be quickly fixed for this release. A proper fix will involve determining which item on the graph is selected for editing. This is the real reason why MantidPlot crashes.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Milestone changed from Release 2.2 to Release 2.3

comment:2 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Owen Arnold

refs #5715. Should fix this issue. No crashes.

Changeset: 951de7b6ca8754ab60c22c070ff68761dfcb212d

comment:4 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Owen Arnold

refs #5715. Should fix this issue. No crashes.

Changeset: 951de7b6ca8754ab60c22c070ff68761dfcb212d

comment:6 Changed 8 years ago by Russell Taylor

  • Status changed from verify to reopened
  • Resolution fixed deleted

Sorry to report that I can easily get a crash by creating a colour-fill plot and clicking around inside it. The crash is in Graph::deselect() because d_legend is NULL.

comment:7 Changed 8 years ago by Owen Arnold

  • Status changed from reopened to accepted

comment:8 Changed 8 years ago by Owen Arnold

refs #5715. Fix ColourMap crash

Changeset: 3e6df81bf0afb5cb86b3f20f0847fbc68a2299da

comment:9 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester : Hopefully this will work nicely now. I've addressed the issue highlighted by Russell. Please try everything you can to break this functionality during testing. See instructions against #5714 for how to replicate the original issue.

comment:10 Changed 8 years ago by Owen Arnold

refs #5715. Fix ColourMap crash

Changeset: 3e6df81bf0afb5cb86b3f20f0847fbc68a2299da

comment:11 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:12 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

Did lots of clicking on various bits and places on a color fill plot and can't make it crash.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6561

Note: See TracTickets for help on using tickets.