Ticket #5725 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

TobyFitResolution model: B matrix calculation is incorrect

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The quantification is going into verification by the scientists but I'm fairly sure part of the B matrix calculation involving the sample rotation matrix is incorrect after more thought.

I'd at least like them to start with something that I think is correct.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Martyn Gigg

Change the U matrix elements used in TobyFit resolution. Refs #5725

Also cleared a warning and some commented out code in ResolutionConvolvedCrossSection

Changeset: 821e7057bd75ef0f80cbc91985f793d35d3912c5

comment:3 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:5 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

Changes consistent with permutations from TobyFit reference frame to Mantid reference frame. A detailed test can be performed only if documentation is present

comment:6 Changed 8 years ago by Martyn Gigg

Change the U matrix elements used in TobyFit resolution. Refs #5725

Also cleared a warning and some commented out code in ResolutionConvolvedCrossSection

Changeset: 821e7057bd75ef0f80cbc91985f793d35d3912c5

comment:7 Changed 8 years ago by Martyn Gigg

Change the U matrix elements used in TobyFit resolution. Refs #5725

Also cleared a warning and some commented out code in ResolutionConvolvedCrossSection

Changeset: 821e7057bd75ef0f80cbc91985f793d35d3912c5

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6571

Note: See TracTickets for help on using tickets.