Ticket #5736 (closed: fixed)
Clean up Fit tests that use random noise
Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | major | Milestone: | Release 2.3 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Wenduo Zhou |
Description
Some fit function tests are actually more stress tests and they add random noise to test whether the fit works. The problem is that the random number sequence is not the same and this causes them to fail every so often when the DELTA in the test is not large enough. We need to be able to guarantee an answer for the unit tests so that we can be confident about what they are doing.
A simple change to a fixed random sequence will be fine
See #5734 which is to have better robustness testing of the fitting engine.
Change History
comment:2 Changed 8 years ago by Martyn Gigg
Tidy up the fitting tests. Refs #5736
Removes a lot of copy-and-pasted code and also ensures that we should no longer see random unit test failures.
Changeset: b62568c6c543f98b8e1f61f0ac0c3ea1b4ac839d
comment:3 Changed 8 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 8 years ago by Martyn Gigg
Tidy up the fitting tests. Refs #5736
Removes a lot of copy-and-pasted code and also ensures that we should no longer see random unit test failures.
Changeset: b62568c6c543f98b8e1f61f0ac0c3ea1b4ac839d