Ticket #5745 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Minor fixes to ImageView

Reported by: Dennis Mikkelson Owned by: Dennis Mikkelson
Priority: minor Milestone: Release 2.3
Component: Mantid Keywords:
Cc: owen.arnold@… Blocked By:
Blocking: Tester: Russell Taylor

Description

  1. The window for the ImageViewer is called “MainWindow”, should definitely be “ImageViewer”
  2. q at the point of the cross hairs, should be labelled |Q|

Change History

comment:1 Changed 8 years ago by Dennis Mikkelson

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Dennis Mikkelson

RE 5745, Minor fixes to ImageView

Made a few more methods virtual in ImageDataSource. Minor formatting fixes. refs #5745

Changeset: ab2ac7328aaf879c9bbe00586e3cf907e5ffbbf6

comment:3 Changed 8 years ago by Dennis Mikkelson

RE 5745, Minor fixes to ImageView

Change title on window to Image Viewer Change label for "q" to |Q| refs #5745

Changeset: 9af722b5a82f524864e344b0791c7b56c8196e3e

comment:4 Changed 8 years ago by Dennis Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

Also removed a little dead code, made a few more functions virtual, and made a couple of trivial changes to formatting.

comment:5 Changed 8 years ago by Dennis Mikkelson

RE 5745, Minor fixes to ImageView

Made a few more methods virtual in ImageDataSource. Minor formatting fixes. refs #5745

Changeset: ab2ac7328aaf879c9bbe00586e3cf907e5ffbbf6

comment:6 Changed 8 years ago by Dennis Mikkelson

RE 5745, Minor fixes to ImageView

Change title on window to Image Viewer Change label for "q" to |Q| refs #5745

Changeset: 9af722b5a82f524864e344b0791c7b56c8196e3e

comment:7 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:8 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

Yes, minor changes.

I notice that method names in these classes don't follow our camelCase naming convention.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6591

Note: See TracTickets for help on using tickets.