Ticket #5748 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Calculation of Energy in ImageView should let user specify direct or indirect mode.

Reported by: Dennis Mikkelson Owned by: Dennis Mikkelson
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: owen.arnold@…, petersonpf@… Blocked By:
Blocking: Tester: Andrei Savici

Description

Not sure how you are calculating the energy mode, without asking the user whether it is direct, indirect etc. We should have the option to change this, or maybe popup a dialog to do so before the main ImageViewer window shows. Owen

Change History

comment:1 Changed 8 years ago by Alex Buts

refs #5748 minor changes

Changeset: 96826929f72025a962f53d112e1eedb9d8dd0cbf

comment:2 Changed 8 years ago by Alex Buts

refs #5748 minor changes

Changeset: 96826929f72025a962f53d112e1eedb9d8dd0cbf

comment:3 Changed 8 years ago by Dennis Mikkelson

RE 5748, initial steps to let user specify EMode.

Added controls to ImageViewer for getting EMode and EFixed from the user.

Refs #5748

Changeset: 93d842b91574dcc7b1085fa2cf14f6e8e30be922

comment:4 Changed 8 years ago by Dennis Mikkelson

RE 5748, Add class for handling EMode to ImageView

Refs #5748

Changeset: 62e5eeb5bcc174f403dd62fac915b43ee0813a86

comment:5 Changed 8 years ago by Dennis Mikkelson

RE 5748 Progress on adding EMode and EFixed to ImageView

refs #5748

Changeset: 27c7b98825a321ff99ffed76f3e70bb6e701a440

comment:6 Changed 8 years ago by Dennis Mikkelson

RE 5748 Finished added emode & efixed to ImageView

ImageViewer now attempts to get Efixed from the workspace for direct and indirect spectrometers, if the user has not specified it and the energy mode. refs #5748

Changeset: 403f1f05aa3e44b55c4f03360b7b610fc84d986a

comment:7 Changed 8 years ago by Dennis Mikkelson

  • Status changed from new to accepted

comment:8 Changed 8 years ago by Dennis Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:10 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to verify
  • Tester Gesner Passos deleted

The image Viewer does allow the user to select the EMode (Diffractometer, Direct Geometry, Indirect Geometry), and also to set the EFixed. Now, some comments from who does not know the field:

  • Is it clear that the combobox with the words (Diffractometer, Direct Geometry and Indirect Geometry) informs the user that he will choose the way he whants to calculate the Energy? The same is valid for EFixed name. Is it clear that name EFixed informs the user that he will configure the parameter that calculates the Energy.
  • The relationship EFixed == 0 <==> Diffractometer and EFixed != 0 <==> not Diffractometer is broadly known? (As long this relationship is forced in ImageViewer without giving feedback way -> If you set EFixed = 0, and change to DirectGeometry, and click on the image, the combobox will go back to Diffractometer, but no warning or notice will be given why it does this)

For these considerations, I don't fell I can judge correctly this ticket.

comment:11 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:12 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

The labels change, so it's OK. A good documentation can help. Maybe change the background color for d-spacing/DeltaE

comment:13 Changed 8 years ago by Dennis Mikkelson

RE 5748, initial steps to let user specify EMode.

Added controls to ImageViewer for getting EMode and EFixed from the user.

Refs #5748

Changeset: 93d842b91574dcc7b1085fa2cf14f6e8e30be922

comment:14 Changed 8 years ago by Dennis Mikkelson

RE 5748, Add class for handling EMode to ImageView

Refs #5748

Changeset: 62e5eeb5bcc174f403dd62fac915b43ee0813a86

comment:15 Changed 8 years ago by Dennis Mikkelson

RE 5748 Progress on adding EMode and EFixed to ImageView

refs #5748

Changeset: 27c7b98825a321ff99ffed76f3e70bb6e701a440

comment:16 Changed 8 years ago by Dennis Mikkelson

RE 5748 Finished added emode & efixed to ImageView

ImageViewer now attempts to get Efixed from the workspace for direct and indirect spectrometers, if the user has not specified it and the energy mode. refs #5748

Changeset: 403f1f05aa3e44b55c4f03360b7b610fc84d986a

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6594

Note: See TracTickets for help on using tickets.