Ticket #5763 (closed: fixed)
Clean up banked event packet parsing
| Reported by: | Ross Miller | Owned by: | Ross Miller |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Stuart Campbell |
Description
The parser code for the ADARA banked events - specifically the event iterator functions - contains a fair amount of redundant code and also doesn't handle a few odd corner cases.
Change History
comment:2 Changed 8 years ago by Ross Miller
Treat pixels from bank 0xFFFFFFFE as error pixels
Refs #5763
Changeset: c920aa62b3145ada58729026fc72949d2e688e66
comment:3 Changed 8 years ago by Ross Miller
Clean up event iterator functions in BankedEventPkt
The event iterator functions (firstEvent() & nextEvent()) are a little easier to understand and handle certain corner cases better (such as packets with multiple sources, but some sources having no events).
Refs #5763
Changeset: b45af3f2e1d093838dc1e74c362ee96d80e34a8d
comment:4 Changed 8 years ago by Ross Miller
- Status changed from accepted to verify
- Resolution set to fixed
comment:5 Changed 8 years ago by Ross Miller
Treat pixels from bank 0xFFFFFFFE as error pixels
Refs #5763
Changeset: c920aa62b3145ada58729026fc72949d2e688e66
comment:6 Changed 8 years ago by Ross Miller
Clean up event iterator functions in BankedEventPkt
The event iterator functions (firstEvent() & nextEvent()) are a little easier to understand and handle certain corner cases better (such as packets with multiple sources, but some sources having no events).
Refs #5763
Changeset: b45af3f2e1d093838dc1e74c362ee96d80e34a8d
comment:7 Changed 8 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
