Ticket #5779 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Fix some error in thermal neutron TOF peak profile and add wiki page

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description (last modified by Wenduo Zhou) (diff)

The calculation on the Lorentzian part in the peak profile ThermalNeutronBk2BkExpConvPV. Complete the implementation.

Modify the definition of Sig-0, Sig-1 and Sig-2 to make it conformed to the definition in manual from what are used in Fullprof .irf file. In Fullprof's .irf file, Sig0 = sig02; Sig1 = sig12; Sig2 = sig22, where sig0, sig1 and sig2 are defined in manual, such that sigma2 = sig02 + sig12 d2 + sig22 d4.

Add wiki page for this function.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

Add method E1(). Refs #5779.

Changeset: 4b9283a7fdf3d8f9d99bc627a3f0365ba0ecf26c

comment:2 Changed 8 years ago by Wenduo Zhou

Add error report. Refs #5779.

Changeset: 87fc70c7f691817a07299ce180b7bddda6d1edf7

comment:3 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:4 Changed 8 years ago by Wenduo Zhou

Add method E1(). Refs #5779.

Changeset: 4b9283a7fdf3d8f9d99bc627a3f0365ba0ecf26c

comment:5 Changed 8 years ago by Wenduo Zhou

Add error report. Refs #5779.

Changeset: 87fc70c7f691817a07299ce180b7bddda6d1edf7

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

moved to Release 2.4

comment:7 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)

comment:8 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)

comment:9 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)

comment:10 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)

comment:11 Changed 8 years ago by Wenduo Zhou

Change definition of Sig0, Sig1 and Sig2. Refs #5779.

Changeset: 185c4934382b0953aa66fddaa1a167b458c99a0f

comment:12 Changed 8 years ago by Wenduo Zhou

Fix unit test. Refs #5779.

Changeset: 791471d23a5b6fa1288f366a0da9da9789dbaab5

comment:13 Changed 8 years ago by Wenduo Zhou

Fix unit test on Win7. Refs #5779.

Changeset: ae7a03594e2f3ffe95302dbf7d366d0346bdaa8d

comment:14 Changed 8 years ago by Wenduo Zhou

Some update. Refs #5779.

Changeset: 4c6ea7d1446a4ce4613ecd808d5cb44fc65fc6ce

comment:15 Changed 8 years ago by Wenduo Zhou

Change definition of Sig0, Sig1 and Sig2. Refs #5779.

Changeset: 185c4934382b0953aa66fddaa1a167b458c99a0f

comment:16 Changed 8 years ago by Wenduo Zhou

Fix unit test. Refs #5779.

Changeset: 791471d23a5b6fa1288f366a0da9da9789dbaab5

comment:17 Changed 8 years ago by Wenduo Zhou

Fix unit test on Win7. Refs #5779.

Changeset: ae7a03594e2f3ffe95302dbf7d366d0346bdaa8d

comment:18 Changed 8 years ago by Wenduo Zhou

Some update. Refs #5779.

Changeset: 4c6ea7d1446a4ce4613ecd808d5cb44fc65fc6ce

comment:19 Changed 8 years ago by Wenduo Zhou

  • Description modified (diff)
  • Summary changed from Fix some error in thermal neutron TOF peak profile to Fix some error in thermal neutron TOF peak profile and add wiki page

comment:20 Changed 8 years ago by Wenduo Zhou

  • Milestone changed from Release 2.4 to Release 2.5

comment:21 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:22 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:23 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Cannot test the ticket because I cannot find the branch it is on.

comment:24 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:25 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

This code to fix this ticket was finished before new workflow. So there is no branch related.

comment:26 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Russell Taylor

comment:27 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The wiki page still needs some fixing....

comment:28 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:29 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

The wiki page can be found at http://www.mantidproject.org/ThermalNeutronBk2BkExpConvPVoigt, due to renaming of the peak profile function.

Last edited 8 years ago by Wenduo Zhou (previous) (diff)

comment:30 Changed 8 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester changed from Russell Taylor to Alex Buts

comment:31 Changed 8 years ago by Alex Buts

  • Status changed from verifying to closed

This function does something and changes to code look reasonable. Attempts to test this function through fitting interface have generated range of problems described in ticket #6716.

As this is old code, merging is not necessary so we may consider it fixed.

comment:32 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6625

Note: See TracTickets for help on using tickets.