Ticket #5783 (closed: fixed)
Reduce Static Analysis Warnings
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
I need to tackle some of the issues highlighted by the static analysis tools. Particularly those that I've generated.
My test coverage is generally quite high, so I trust that making these kind of changes will trigger failure of incremental tests for any stupid mistake. Also a good idea to start doing this early in the iteration so that any issues that arise can be ironed out prior to the release.
Change History
comment:2 Changed 8 years ago by Owen Arnold
refs #5783. Duplicate code.
Changeset: f833685bcea34d59836e575383588fa6a5e742d1
comment:3 Changed 8 years ago by Owen Arnold
refs #5783. Duplicate code in MergeRuns.
Changeset: c1930b6655cf9f8db6cb448bed3bf3945c2caeb4
comment:4 Changed 8 years ago by Owen Arnold
refs #5783. Duplicate code in StitchGroup1DTest.
Changeset: 20e7ceabbf59057edd3263eca0d34fe089533df0
comment:5 Changed 8 years ago by Owen Arnold
refs #5783. Fix storage type.
Changeset: 69d85057f34fa6d160d56f88cb6588552151e853
comment:6 Changed 8 years ago by Owen Arnold
refs #5783. Ensure ex safe deallocation before allocation.
Changeset: 8809dde4fc5f0745fffd183753b4726bd8af2c02
comment:7 Changed 8 years ago by Owen Arnold
refs #5783. Duplicate code.
Changeset: f833685bcea34d59836e575383588fa6a5e742d1
comment:8 Changed 8 years ago by Owen Arnold
refs #5783. Duplicate code in MergeRuns.
Changeset: c1930b6655cf9f8db6cb448bed3bf3945c2caeb4
comment:9 Changed 8 years ago by Owen Arnold
refs #5783. Duplicate code in StitchGroup1DTest.
Changeset: 20e7ceabbf59057edd3263eca0d34fe089533df0
comment:10 Changed 8 years ago by Owen Arnold
refs #5783. Fix storage type.
Changeset: 69d85057f34fa6d160d56f88cb6588552151e853
comment:11 Changed 8 years ago by Owen Arnold
refs #5783. Ensure ex safe deallocation before allocation.
Changeset: 8809dde4fc5f0745fffd183753b4726bd8af2c02
comment:12 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester: I can't provide any guidance for this. Outwardly, all our tests should still be working and the supplied fixes should have done what they were labelled to do.
Note that I could have made these changes under the trial changes ticket, but I think it's better to have a more structured ticket-code association.
comment:13 Changed 8 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:14 Changed 8 years ago by Nick Draper
- Status changed from verifying to closed
accepted as not realistically possible to test, other than by the whole testing process and unscripted testing
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6629
