Ticket #5796 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

FilterEventsHighFrequency: Make InputCalFile property optional.

Reported by: Stuart Campbell Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Andrei Savici

Description

Does the InputCalFile property really have to be mandatory ? Most beamlines do not have one.

Change History

comment:1 in reply to: ↑ description Changed 8 years ago by Wenduo Zhou

  • Status changed from new to verify
  • Resolution set to wontfix

Replying to Stuart Campbell:

Does the InputCalFile property really have to be mandatory ? Most beamlines do not have one.

FilterEventsHightFrequency is only a prototype for event filtering. Its functionality is realized by FilterEvents.

On the other hand, due to the nature of the fast log, the calibration of the time offset between sample and detectors cannot be ignored.

comment:2 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to reopened
  • Cc petersonpf@… added; petersonpf@… removed
  • Resolution wontfix deleted

If this is only a prototype and is replaced by FilterEvents, then it should be marked deprecated.

I agree that the geometry has to be calibrated, but the cal files are a diffraction only way of doing this. Other techniques use other methods.

comment:3 Changed 8 years ago by Wenduo Zhou

Deprecate the algorithm. Refs #5796.

Changeset: 0ae1efe45f0dfa3ecbe6b1fe1a00c94edc0dfd5c

comment:4 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:5 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:7 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to verify
  • Tester Vickie Lynch deleted

comment:8 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:9 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

You should change the wiki as well

comment:10 Changed 8 years ago by Wenduo Zhou

Deprecate the algorithm. Refs #5796.

Changeset: 0ae1efe45f0dfa3ecbe6b1fe1a00c94edc0dfd5c

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6642

Note: See TracTickets for help on using tickets.